Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idle vehicles turn towards enemies and shoot automatically #405

Merged
merged 5 commits into from Oct 22, 2018
Merged

Conversation

FilmBoy84
Copy link
Collaborator

Idle vehicles turn towards enemies and shoot automatically (turning was not implemented before).

Co-Authored-By: andreycreator andreycreator@users.noreply.github.com

Idle vehicles turn towards enemies and shoot automatically (turning was not implemented before).

Co-Authored-By: andreycreator <andreycreator@users.noreply.github.com>
@FilmBoy84 FilmBoy84 requested a review from JonnyH October 15, 2018 11:15
…t screen now

Fixed: Agent and vehicle location screens. Right click opens equipment screen now (like in original game). It was no difference between mouse buttons before and equipment screen could be opened with any button.
Co-Authored-By: andreycreator <andreycreator@users.noreply.github.com>
@Jarskih
Copy link
Contributor

Jarskih commented Oct 16, 2018

Did you use clang format on this? On windows you can run "clang_format_win.bat" to fix formatting issues.

@FilmBoy84
Copy link
Collaborator Author

Many thanks for the tip regarding clang format
I manually formatted this, so if there's a means to check and fix via clang ill check it out +1

FilmBoy84 and others added 2 commits October 18, 2018 12:05
Ran a massive check on all OpenApoc components
Fixing formatting errors and spelling mistakes
Many are simply corrections to // comments such as "// namespace XXXX"
But given how many instances have namespace spelt incorrectly that's probably not a bad thing
In short, no new features, but readability improvements

Thanks to Jarskih for his help in doing this <3

Co-Authored-By: Jari <jari@studyabroad.live>
Just to fix some issues from using Clang Format 8 instead of 4 by mistake :)
@FilmBoy84 FilmBoy84 requested review from pmprog and a team October 18, 2018 17:03
@JonnyH
Copy link
Collaborator

JonnyH commented Oct 22, 2018

There's a lot of noise from unrelated format changes (clang-format 4.0 doesn't add the missing closing namespace comments, but doesn't reject them either - while later versions add them, so you running through a later version then 4.0 caused them all to appear)

But that's fine, I like them there anyway, and while it might cause a slightly dirty history... meh

@JonnyH JonnyH merged commit 9742397 into master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants