Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Frag message output with icons #11
Excuse me Idrone, you did not answer to a question I did here:
PS: You already know, I don't see any reason for hiding the attacker name, in case of indirect kill.
PPS: just asking for curiosity... why does the "case MOD_BFG:" section is completely empty? Because so it automatically takes the same settings as "case MOD_BFG_SPLASH" which is right under it? You know I'm not good with C...
UPDATE: Wait, for some reason I was not seeing your latest changes. I have to check them now.
Update2: About the "we don't know what is was", I see you added some code there (depending from obituary mode), but I don't exactly understood what it does (I would have expected something like "causeShader = cgs.media.skullShader").
About drawing attacker name (if available), I see now you show it. Thank you!
It "falls through" to the next case since there is no
Ok, I have checked it out and also tryed playing it. Looks good. A bit hard to read on my screen but I could not read the console either, so it does not matter.
Regarding the code:
Also something like this:
The "32" should either be replaced by a "#define MAX_FRAG_NAME_LENGTH" or a "sizeof".
should properly be
I would greatly prefer curly brackets here:
While it is only 1 logical line it is 3 physical lines and I would mark it. You also used curly brackets other places where the if content was more than 1 physical line.
or maybe just
Aside from that the code looked solid.
Perhaps the commits should be squashed before merging. While it is easy enough to read all the commits as one in this pull request it might be harder in the commit history.