Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose handler classes in top level import #47

Closed
pllim opened this issue Dec 7, 2018 · 2 comments
Closed

Expose handler classes in top level import #47

pllim opened this issue Dec 7, 2018 · 2 comments

Comments

@pllim
Copy link
Contributor

pllim commented Dec 7, 2018

Instead of

 from baldrick.github.github_api import PullRequestHandler

would like to have

 from baldrick import PullRequestHandler
@Cadair
Copy link
Member

Cadair commented Dec 8, 2018

I think I would prefer

from baldrick.github import PullRequestHandler

Just from a namespace perspective, but either way works.

@pllim
Copy link
Contributor Author

pllim commented Dec 9, 2018

Unless you plan to expand to baldrick.gitlab, baldrick.bitbucket, etc, I don't see the point for more typing. 😉

@pllim pllim mentioned this issue Dec 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cadair @pllim