Fix 16 chan #136

merged 5 commits into from Jan 4, 2017


None yet

2 participants

aj-ptw commented Jan 4, 2017 edited


New Features

  • New simulator option simulatorDaisyModuleCanBeAttached - Boolean, deafults to true, allows the simulation of the a hot swapped daisy board or simulates a misinformed module.
  • New EventEmitter - hardSet - for when the module detects the board is not configured as the options for the module intended and tries to save itself. i.e. when the daisy option is true and a soft reset message is parsed and the module determines that a daisy was not detected, the module will emit hardSet then send an attach daisy command to recover. Either error will be emitted if unable to attach or ready will be emitted if success.
  • Add example for streaming with daisy and hardSet.

Breaking changes

  • .setInfoForBoardType() changed to .overrideInfoForBoardType() to elevate it's dangerous nature.
  • .setMaxChannels() changed to .hardSetBoardType() and input changed from numerical to string: 8 and 16 to default and daisy respectively.

Bug Fixes

  • Fixes #131 - 16 chan not working by sending a channel command and parsing the return.
  • Fixed bug where end of transmission characters would not be ejected from buffer.


  • Separated radio tests from main board test file.
aj-ptw added some commits Jan 3, 2017
@aj-ptw aj-ptw Add: max channel support for simulator 0dd0ece
@aj-ptw aj-ptw Add tests for new daisy code and Enh separated radio tests from main …
…board test
@aj-ptw aj-ptw Bump minor version because of breaking changes
@aj-ptw aj-ptw added the in progress label Jan 4, 2017
codecov-io commented Jan 4, 2017 edited

Current coverage is 94.46% (diff: 95.74%)

Merging #136 into master will increase coverage by 0.01%

@@             master       #136   diff @@
  Files             4          4          
  Lines          2290       2368    +78   
  Methods         138        140     +2   
  Messages          0          0          
  Branches        494        509    +15   
+ Hits           2163       2237    +74   
- Misses          127        131     +4   
  Partials          0          0          

Powered by Codecov. Last update 70a6165...2523f72

aj-ptw added some commits Jan 4, 2017
@aj-ptw aj-ptw Fix #131 and add example for daisy with hardset
@aj-ptw aj-ptw Update readme for new functions and emitters
@aj-ptw aj-ptw merged commit 3f42be4 into OpenBCI:master Jan 4, 2017

3 checks passed

codecov/patch 95.74% of diff hit (target 94.45%)
codecov/project 94.46% (+0.01%) compared to 70a6165
continuous-integration/travis-ci/pr The Travis CI build passed
@aj-ptw aj-ptw deleted the aj-ptw:fix-16-chan branch Jan 4, 2017
@aj-ptw aj-ptw removed the in progress label Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment