/OpenBCI_Python

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

2's complement 24->32 bits conversion #37

Closed
atom2626 opened this Issue Apr 2, 2017 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@atom2626 @jfrey-xx
@atom2626

atom2626 commented Apr 2, 2017 • edited

I borrowed your implementation of conv24bitsToInt (referenced your name/work)

However I think:
if (unpacked[0] >= 127):

Should be replaced by
if (unpacked[0] > 127):

as 127 is written 0111 1111, sign bit is off.

jfrey-xx closed this in c36abb5 Apr 4, 2017

@jfrey-xx
Member

jfrey-xx commented Apr 4, 2017

Wow, nice catch! Thanks for the fix, it's committed now :)
@atom2626

atom2626 commented Apr 4, 2017

No problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment