351-352: self link by version and funds confirmations #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BohoCode
approved these changes
Mar 17, 2021
BohoCode
deleted the
issue/351-self-link-by-versions-352-fundsconfirmations
branch
matt-wills
reviewed
Mar 17, 2021
| import static com.forgerock.openbanking.integration.test.support.JWT.jws; | ||
| import static org.mockito.BDDMockito.given; | ||
|
|
||
| // TODO: DRAFT to finished |
There was a problem hiding this comment.
Is is perhaps too early to add these ITs if they're not ready and don't yet do anything?
| String xFapiCustomerIpAddress, | ||
| String xFapiInteractionId, | ||
| String xCustomerUserAgent, | ||
| String clientId, | ||
| HttpServletRequest request, |
| @@ -212,7 +158,7 @@ private OBFundsConfirmationConsentResponse1 packageResponse(FRFundsConfirmationC | |||
| .consentId(consent.getId()) | |||
| ) | |||
| .meta(new Meta()) | |||
| .links(resourceLinkService.toSelfLink(consent, discovery -> discovery.getV_3_0().getGetFundsConfirmationConsent())) | |||
| ; | |||
| .links(resourceLinkService.toSelfLink(consent, discovery -> discovery.getVersion(VersionPathExtractor.getVersionFromPath(request)).getGetFundsConfirmationConsent())); | |||
| produces = {"application/json; charset=utf-8"}, | ||
| method = RequestMethod.GET) | ||
| ResponseEntity<OBFundsConfirmationConsentResponse1> getFundsConfirmationConsentsConsentId( | ||
| @ApiParam(value = "ConsentId", required = true) | ||
| @PathVariable("ConsentId") String consentId, | ||
|
|
||
| @ApiParam(value = "An Authorisation Token as per https://tools.ietf.org/html/rfc6750", required = true) | ||
| @RequestHeader(value = "Authorization", required = true) String authorization, | ||
| @RequestHeader(value = "Authorization") String authorization, |
| .risk(toOBRisk1(domesticConsent.getRisk())) | ||
| .meta(new Meta()); | ||
| } | ||
|
|
||
| protected OBDiscoveryAPILinksPayment4 getVersion(DiscoveryConfigurationProperties.PaymentApis discovery) { |
There was a problem hiding this comment.
Nice work. Good to fix earlier versions of payments as well 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
#351
#352