Merge pull request #1353 from OpenBazaar/migration-logs

Improve migration logs

repo/migration.go

@@ -1,6 +1,7 @@
 package repo
 
 import (
+	"errors"
 	"io/ioutil"
 	"os"
 	"path"
@@ -15,25 +16,29 @@ type Migration interface {
 	Down(repoPath string, dbPassword string, testnet bool) error
 }
 
-var Migrations = []Migration{
-	migrations.Migration000{},
-	migrations.Migration001{},
-	migrations.Migration002{},
-	migrations.Migration003{},
-	migrations.Migration004{},
-	migrations.Migration005{},
-	migrations.Migration006{},
-	migrations.Migration007{},
-	migrations.Migration008{},
-	migrations.Migration009{},
-	migrations.Migration010{},
-	migrations.Migration011{},
-	migrations.Migration012{},
-	migrations.Migration013{},
-	migrations.Migration014{},
-	migrations.Migration015{},
-	migrations.Migration016{},
-}
+var (
+	ErrUnknownSchema = errors.New("unable to migrate unknown schema")
+
+	Migrations = []Migration{
+		migrations.Migration000{},
+		migrations.Migration001{},
+		migrations.Migration002{},
+		migrations.Migration003{},
+		migrations.Migration004{},
+		migrations.Migration005{},
+		migrations.Migration006{},
+		migrations.Migration007{},
+		migrations.Migration008{},
+		migrations.Migration009{},
+		migrations.Migration010{},
+		migrations.Migration011{},
+		migrations.Migration012{},
+		migrations.Migration013{},
+		migrations.Migration014{},
+		migrations.Migration015{},
+		migrations.Migration016{},
+	}
+)
 
 // MigrateUp looks at the currently active migration version
 // and will migrate all the way up (applying all up migrations).
@@ -42,15 +47,20 @@ func MigrateUp(repoPath, dbPassword string, testnet bool) error {
 	if err != nil && !os.IsNotExist(err) {
 		return err
 	} else if err != nil && os.IsNotExist(err) {
+		log.Noticef("missing repo version file, migrating from 0")
 		version = []byte("0")
 	}
 	v, err := strconv.Atoi(strings.Trim(string(version), "\n"))
 	if err != nil {
 		return err
 	}
+	if v > len(Migrations) {
+		log.Errorf("binary can migrate schemas up to version %03d but this schema is already at %03d", len(Migrations)-1, v)
+		return ErrUnknownSchema
+	}
 	x := v
-	for _, m := range Migrations[v:] {
-		log.Noticef("Migrating repo to version %d\n", x+1)
+	for i, m := range Migrations[v:] {
+		log.Noticef("running migration %03d changing schema to version %03d...\n", i, x+1)
 		err := m.Up(repoPath, dbPassword, testnet)
 		if err != nil {
 			log.Error(err)