Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tor integration #99

Closed
JustinDrake opened this issue Aug 26, 2016 · 10 comments
Closed

Tor integration #99

JustinDrake opened this issue Aug 26, 2016 · 10 comments
Labels

Comments

@JustinDrake
Copy link
Contributor

@JustinDrake JustinDrake commented Aug 26, 2016

As of August 26, the openbazaar-go codebase doesn't seem to have code for Tor integration. The intent of this issue is to push forward discussion about Tor integration, as this one of the most requested features for OpenBazaar. I'll start with a couple questions:

  1. Is Tor integration planned for the OB2.0 initial release?
  2. I tried to find a Tor library in Go but couldn't find anything satisfactory. Which Tor library is planned to be used for the integration?
@tyler-smith
Copy link
Member

@tyler-smith tyler-smith commented Aug 26, 2016

TOR support will come from a TOR transport for IPFS which needs to be written. There is an issue for it here: ipfs/notes#37

There's not much happening with it. If anybody was interested in working on one it would be a great way to contribute to OB IMO.

@cpacia
Copy link
Member

@cpacia cpacia commented Aug 27, 2016

It should probably:

  1. Detect if tor is running by querying the control port
  2. If it's running and tor hasn't been set in the config
    2a) stop initialization and ask them if they want to use tor.
    2b) if so, configure tor and proceed with startup.

It should also have the option to run in onion only mode or dual stack mode.

@cpacia
Copy link
Member

@cpacia cpacia commented Aug 27, 2016

@cpacia
Copy link
Member

@cpacia cpacia commented Aug 27, 2016

Ideally we should be able to make it also use the socks proxy to connect to clearnet nodes via Tor. That might be more complicated as I think we'd have to modify the libp2p dialer. On the other hand, I'm not sure if that functionality will be desired. Connecting only to onion or dual-stack nodes from Tor is probably sufficient.

@cpacia
Copy link
Member

@cpacia cpacia commented Sep 4, 2016

Another requirement for this should be a full node wallet implementation. The spv wallet likely leaks more private data than a Tor user would find acceptable. This would require a wallet implementation that either connects to bitcoind or packages btcd as an alternative.

@cpacia cpacia added the feature label Sep 6, 2016
@cpacia cpacia added TODO and removed feature labels Oct 8, 2016
@cpacia cpacia mentioned this issue Nov 11, 2016
12 of 30 tasks complete
@cpacia cpacia added this to the v1.0-alpha milestone Nov 11, 2016
@OstrichEgg
Copy link

@OstrichEgg OstrichEgg commented Jan 18, 2017

I just created a $100 (USD) bounty for the solving of this issue (i.e. integration of Tor into openbazaar-go).
https://www.bountysource.com/issues/37322830-tor-integration

I will probably post additional bounties for this issue as the funds become available for dispensing. Good luck, devs!

@cpacia
Copy link
Member

@cpacia cpacia commented Jan 18, 2017

I have it roughly working here https://github.com/cpacia/openbazaar-go/tree/tor

But i'm waiting for IPFS 0.4.5 because I integrate it because there were tons of dependency issues that I had to manually fix that will probably be fixed in 0.4.5

@OstrichEgg
Copy link

@OstrichEgg OstrichEgg commented Jan 19, 2017

@cpacia , Glad to hear it! I think Bountysource automatically dispenses the bounty when its bots detect that the open issue has been officially marked as Resolved to the dev whose pull request resulted in the completion of the issue.

@cpacia
Copy link
Member

@cpacia cpacia commented Feb 8, 2017

PR #342

@cpacia cpacia mentioned this issue Feb 8, 2017
Merged
4 of 4 tasks complete
@OstrichEgg
Copy link

@OstrichEgg OstrichEgg commented Feb 9, 2017

cpacia, once your PR is accepted and issue is closed, follow my earlier link to claim the bounty.

@cpacia cpacia closed this in #342 Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.