This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Increase chat timestamp resolution #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
placer14
force-pushed
the
1545-increase-chat-timestamp-resolution
branch
from
fcfc1fe
to
76ea8fc
Compare
cpacia
reviewed
Apr 18, 2019
cpacia
reviewed
Apr 18, 2019
cpacia
reviewed
Apr 18, 2019
cpacia
approved these changes
Apr 18, 2019
|
Looks really good |
Messages are stored with seconds which cause messages received within the same second to have non-deterministic ordering. This increased resolution will allow these messages to maintain proper order.
placer14
force-pushed
the
1545-increase-chat-timestamp-resolution
branch
from
76ea8fc
to
372281f
Compare
|
We're going to move forward with this fix seeing that we have confirmed it properly resolves #1545. Need to update timestamps in the JSON API to ensure the full resolution can be shown in the string representation. Recommendation is to use RFC3339 which looks like |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1545