Skip to content
This repository has been archived by the owner. It is now read-only.

Using a light scheme on dark theme/dark scheme on native theme #65

Closed
Astalaseven opened this issue Aug 31, 2014 · 18 comments
Assignees
Labels
Bug
Milestone

Comments

@Astalaseven
Copy link
Contributor

@Astalaseven Astalaseven commented Aug 31, 2014

Preferences -> Style -> Global style = native -> Color scheme = rrt -> Ok
Back to Preferences, Style, Ok, scheme changes.

The 'after' is not always the same, sometimes only the background is changed (to dark grey)

schemefirst
schemeafter

edit: grey version:
schemeaftergrey

@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

@ColinDuquesnoy ColinDuquesnoy commented Aug 31, 2014

So that last two image are rtt + native and to get that you just did: preferences -> style tab -> OK ?

Not happening for me here, will try on windows tomorrow ;-)

@Astalaseven

This comment has been minimized.

Copy link
Contributor Author

@Astalaseven Astalaseven commented Aug 31, 2014

Sorry, I forgot to say you have to be on the dark theme first.
And closing the app and reopening fix the scheme.

@Astalaseven

This comment has been minimized.

Copy link
Contributor Author

@Astalaseven Astalaseven commented Aug 31, 2014

If you use the native theme, you can change to dark theme + autumn, the background is then dark, should be blank.

@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

@ColinDuquesnoy ColinDuquesnoy commented Aug 31, 2014

Ok I got it! I can reproduce it!

@Astalaseven

This comment has been minimized.

Copy link
Contributor Author

@Astalaseven Astalaseven commented Aug 31, 2014

My bad, I didn't explain it well, I got always problems to reproduce myself :(
Nice to know you could reproduce it :)

@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

@ColinDuquesnoy ColinDuquesnoy commented Aug 31, 2014

Damn this is a tricky one ;-)

ColinDuquesnoy added a commit that referenced this issue Aug 31, 2014
Fix #65
Stylesheet must be applied first for the fix made for pyQode/pyqode.core#147 to be applied
@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

@ColinDuquesnoy ColinDuquesnoy commented Aug 31, 2014

I think I got it: the fix I made for #61 did not apply when you came from the native style because the stylesheet is set last. The fix consists in overwriting the app stylesheet if there was one. As the stylesheet is set at the end of the apply_setttings procedure, the fix never triggered since QApplication.styleSheet() returns an empty string. It triggers fine when you close and reopen the editor because the application now has a stylesheet defined. Wow...

@Astalaseven

This comment has been minimized.

Copy link
Contributor Author

@Astalaseven Astalaseven commented Aug 31, 2014

Does that explain that the scheme first is correct then change?
I mean, if I come from the dark theme-autumn and go to native theme-rrt, the scheme is correct. But going back to preferences and clicking Ok change it to something lighter.
Is it another bug? Or perhaps it's late and I didn't understand all your explanation ^^

@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

@ColinDuquesnoy ColinDuquesnoy commented Aug 31, 2014

But going back to preferences and clicking Ok change it to something lighter.

I think this is another bug yes, one that does not happen for me here on linux.

@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

@ColinDuquesnoy ColinDuquesnoy commented Aug 31, 2014

But going back to preferences and clicking Ok change it to something lighter.

You are in native or dark theme at that moment?

@Astalaseven

This comment has been minimized.

Copy link
Contributor Author

@Astalaseven Astalaseven commented Aug 31, 2014

From native-default (OK), I change to dark-autumn (not OK).

darkautumn1

Going back into the Preferences, clicking again on autumn then Ok it works.

darkautumn2

@Astalaseven

This comment has been minimized.

Copy link
Contributor Author

@Astalaseven Astalaseven commented Aug 31, 2014

    But going back to preferences and clicking Ok change it to something lighter.

You are in native or dark theme at that moment?

1- Dark theme - autumn scheme

darkautumn

2- Native theme - rrt scheme

nativerrt0

3- Native theme - rrt scheme

nativerrt

@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

@ColinDuquesnoy ColinDuquesnoy commented Aug 31, 2014

Ok thanks I will see if I can reproduce that on Windows. That's not happening on linux apparently and I fixed another bug (maybe).

@ColinDuquesnoy ColinDuquesnoy added the Bug label Aug 31, 2014
@ColinDuquesnoy ColinDuquesnoy added this to the 4.0 milestone Aug 31, 2014
@ColinDuquesnoy ColinDuquesnoy self-assigned this Aug 31, 2014
@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

@ColinDuquesnoy ColinDuquesnoy commented Sep 1, 2014

I can reproduce it on Windows 7!

bug

ColinDuquesnoy added a commit to pyQode/pyqode.core that referenced this issue Sep 1, 2014
@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

@ColinDuquesnoy ColinDuquesnoy commented Sep 1, 2014

Fixed in pyqode.core dev branch. It seems like I have to keep on using a stylesheet on windows once one has been used. The problem with using a custom stylesheet for background is that it also modifies the style of the scrollbars, especially on platforms such as kde. This is mostly invisible on Windows.

If there is no other issues, I will upload a rc3 release for you to try

Edit: better wording (well kinda)

@ColinDuquesnoy

This comment has been minimized.

@Astalaseven

This comment has been minimized.

Copy link
Contributor Author

@Astalaseven Astalaseven commented Sep 1, 2014

Seems to be well fixed on my side! Nice work :)

@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

@ColinDuquesnoy ColinDuquesnoy commented Sep 1, 2014

Cool :)

During this week I will update the manual and update pyqode documentation, when this is done and if there is no other issue I will make the final release. So take your time to test the editor ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.