Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oc_capture broken with TRUSTED change #227

Closed
RayZopf opened this issue Jul 21, 2019 · 3 comments

Comments

@RayZopf
Copy link

@RayZopf RayZopf commented Jul 21, 2019

What version of OpenCollar are you using?
7.2

What behavior did you expect?
'capture release' command working
getting the correct menu with button 'Release'

What behavior did you see instead?
after capturing one still gets a capture yes/no menu
'capture release' silently fails

What steps does someone need to take to reproduce the problem?
capture a wearer and try to release via command and menu

Fix with annotations and further questions attached
oc_capture.txt

@SilkieSabra

This comment has been minimized.

Copy link
Contributor

@SilkieSabra SilkieSabra commented Jul 21, 2019

I was able to duplicate this issue with the following steps:

Expected: Using OC 7.2, when capture is active, a non-owner captures the wearer then issues [prefix] capture release as instructed in the capture text.

What happens: Capture release does not result in release

To duplicate.

  1. Wearer sets capture on.
  2. User with no other means of access captures wearer.
  3. User types [prefix] capture release
  4. Wearer sees she is still captured.
  5. User attempts to open the capture menu again and gets the capture start menu, not the release menu. User receives request to capture and this time declines.
  6. Wearer presses Capture again and this time gets the Release button meant for the user.
@RayZopf

This comment has been minimized.

Copy link
Author

@RayZopf RayZopf commented Jul 21, 2019

after checking again, it is afaik right that the wearer while beeing captured gets the 'Release' button too
the wearer then just is blocked from using the release command

@zontreck

This comment has been minimized.

Copy link
Collaborator

@zontreck zontreck commented Jul 22, 2019

Fixed - Will release a 7.3 update shortly

@zontreck zontreck closed this Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.