WIP: Upgrade to symfony 7.4 #557
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In test/development mode, don't flood the console with queries. Update mariaDb version to match production. In the devbox, we want deprecations to fail the pipeline. In Github, we don't want that, as dependabot updates or small package udates should not cause the build to fail. We will handle the deprecations once a developer works on the project. Add a separate deprecation.log in development mode.
Surfnet\StepupMiddleware\CommandHandlingBundle\Root\Command\FooBarCommand::$snakeCase is deprecated
MagicClosureTwigExtensionToNativeMethodsRector + attribute rules.
Prior to this change, organised imports was not enforced, but required by coding guidelines. This would result in PR feedback about unused imports, usage of fqn in code, etc. This change auto fixes & enforces correct import usage via phpcs / phpcbf.
…rTypeDeclarationSQL
…ations to attributes for everything.
…sons. Only except camelcase method names and line lenghts.
RecastingRemovalRector
… is accessible by default now. RemoveReflectionSetAccessibleCallsRector
…nRector, NullToStrictStringFuncCallArgRector, FunctionFirstClassCallableRector
Tests cannot be abstract. So PHPunit does not allow it to end on 'Test' anymore.
Math is no longer needed as an explicit dependency.
xss_protection is deprecated. The recommended unsafe-inline al not allowed.
twigphp/Twig@7c38fc2 Disable doctrine automapping deprecation warning.
GetFiltersToAsTwigFilterAttributeRector InvokableCommandInputAttributeRector
…ds on it. Running `./bin/console` produces an error without it as jms/translation-bundle tries to instatiate it.
…ble in the cli, because they were not autoconfigured. This change ensures they are registered by adding autoconfigure to the console_commands.yml service definition. And adds a test to validate that. And adds autoconfigure to all other service definitions to ensure all attribute services can be picked up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.