Reference issue, see mantis #140 #140

Closed
OpenDUNE opened this Issue Dec 3, 2012 · 4 comments

Projects

None yet

3 participants

@OpenDUNE OpenDUNE closed this Dec 3, 2012
@wangds
Contributor
wangds commented Jul 7, 2013

This bug was originally about refineries not going out of the busy state.
This is due to the some translation errors concerning an object's "script variables[4]".

In commit b794766, a change was made to the Structure_SetState line to "fix" the refinery behaviour, but it seems to be incorrect.

The error is probably in commit 451e6f0.
f__0C10_0182_0012_B114 was replaced by Object_Script_Variable4_Clear, but some of the logic was lost. In particular, there are some missing calls to emu_Tools_Index_GetUnit.

@wangds wangds reopened this Jul 7, 2013
@wangds
Contributor
wangds commented Jul 12, 2013

The patch in commit b794766 is correct.
For the record, "emu_Object_ClearScriptVariable4" has been combined
into Object_Script_Variable4_Set with encoded=0. Either I guessed the
fix correctly, or I forgot my own fix.

It's a bit confusing as f__0C10_0182_0012_B114 has now taken the name
"Object_Script_Variable4_Clear." Still need to work out what the
untranslated code in f__0C10_0182_0012_B114 do.

@miniupnp
Contributor
miniupnp commented Feb 9, 2017

I want to help, but I don't understand what is the problem here...

@wangds
Contributor
wangds commented Feb 10, 2017

There was some bug with the scripts, introduced somewhere during the
translation. I think it caused refineries to sometimes stay in the
busy state, meaning that harvesters wouldn't automatically return to
it when they were full.

I'm pretty sure it is fixed, can't remember why I reopened it.
Happy to close it.

@miniupnp miniupnp closed this Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment