"Load a game" string missing on main menu

[IgalOre]

Hello there,

First of all , thank you for reviving old memories by resurecting this project alive !!!

I started to compile around, and encountered tiny but annoying issue:
When game starts, after intro, on main menu, instead of showing "Load a Game" options in third line, nothing coming out : (https://f.cloud.github.com/assets/3233971/56473/c4c88b78-5b16-11e2-878c-821d67c7a5d5.jpg)

I'm not sure if this is due to damaged ENGLISH.PAK file or something, but after small look throw the code, at opendune.c : 1736 and 1738, in mainMenuStrings array, entries STR_LOAD_GAME leading to nowhere .... I had replaced them with STR_LOAD_A_GAME and now having menu as expected ...

i'm running all on Windows 7 pro, compiling GitHub version 0.8 OpenDune with MSVC 2008
Should i commit this as it is, or should i look deeper WTF ?!?
![Dune2_MainScreen_LoadIssue]

[IgalOre]

There one more line to change out there , on opendune.c : 1890 ....

[TrueBrain]

Which datafiles do you use? Looking at your bug, I am guessing 1.07US.

1.07US is the only version which has a different string for Load Game. I thought we had a patch in place to make sure both work, but clearly it is not working as expected ;)

[IgalOre]

I took game data files from here - http://duneii.com/downloads/ , i think that one corresponds to 1.07US ...

[wangds]

HitSquad release is also affected.

Somewhat related issue: do you intend on supporting the US sound filenames too? The English files there don't have the 'Z' prefix.

[glx22]

Maybe something to check in fdf808d

[TrueBrain]

To add to that: in that (long) patch there is a line:

if (s_stringsCount == STR_LOAD_GAME) s_strings[s_stringsCount++] = strdup(s_strings[STR_LOAD_A_GAME]);

Although ugly, basically what it does is: if we read any language file that misses the STR_LOAD_GAME (1.07EU only has it), copy STR_LOAD_A_GAME to it. This should fix all other versions, and when we wrote it, it did.

Now I guess the question is: what changed and broke it :D