New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indestructible enemy buildings #279

Closed
eLEcTRiCZiTy opened this Issue Dec 7, 2016 · 13 comments

Comments

Projects
None yet
4 participants
@eLEcTRiCZiTy

eLEcTRiCZiTy commented Dec 7, 2016

At the end of the second Harkonnen mission against Ordos the player can not destroy enemy buildings (has full hp and seems indestructible).

I also encountered a problem that the enemy built a building across the player's units.

Game save:
_SAVE002.ZIP

@miniupnp

This comment has been minimized.

Show comment
Hide comment
@miniupnp

miniupnp Dec 16, 2016

Contributor

well indeed. You destroyed all other Ordos buildings, right ?
what version of OpenDUNE did you use to make this savegame ?

Contributor

miniupnp commented Dec 16, 2016

well indeed. You destroyed all other Ordos buildings, right ?
what version of OpenDUNE did you use to make this savegame ?

@eLEcTRiCZiTy

This comment has been minimized.

Show comment
Hide comment
@eLEcTRiCZiTy

eLEcTRiCZiTy Dec 16, 2016

All other enemy buildings are destroyed.

Sorry, the device on which I played, is currently unavailable.
Savegame is from a game version downloaded the day I created this issue.

eLEcTRiCZiTy commented Dec 16, 2016

All other enemy buildings are destroyed.

Sorry, the device on which I played, is currently unavailable.
Savegame is from a game version downloaded the day I created this issue.

@miniupnp

This comment has been minimized.

Show comment
Hide comment
@miniupnp

miniupnp Dec 16, 2016

Contributor

which OS ?

Contributor

miniupnp commented Dec 16, 2016

which OS ?

@miniupnp

This comment has been minimized.

Show comment
Hide comment
@miniupnp

miniupnp Dec 16, 2016

Contributor

looks like the buildings are not indestrutible but have 10000+ life points.
it should be 100 or something...
I'm waiting, they will finally be destroyed :)
I need to know which OpenDUNE version you used. Which OS, which downloaded file

Contributor

miniupnp commented Dec 16, 2016

looks like the buildings are not indestrutible but have 10000+ life points.
it should be 100 or something...
I'm waiting, they will finally be destroyed :)
I need to know which OpenDUNE version you used. Which OS, which downloaded file

@puddlecoded

This comment has been minimized.

Show comment
Hide comment
@puddlecoded

puddlecoded Feb 22, 2017

I've also experienced the indestructible building issue, OSX findversion.sh says 1
Also second Harkonnen mission vs Ordos. the buildings left are Construction Yard and Light Vehicle Factory

puddlecoded commented Feb 22, 2017

I've also experienced the indestructible building issue, OSX findversion.sh says 1
Also second Harkonnen mission vs Ordos. the buildings left are Construction Yard and Light Vehicle Factory

@miniupnp

This comment has been minimized.

Show comment
Hide comment
@miniupnp

miniupnp Feb 22, 2017

Contributor

@puddlecoded so you have OS X. Which version ?
have you downloaded a ecompiled package ? or compiled from sources ? which sources (git checkout ?)

Contributor

miniupnp commented Feb 22, 2017

@puddlecoded so you have OS X. Which version ?
have you downloaded a ecompiled package ? or compiled from sources ? which sources (git checkout ?)

@puddlecoded

This comment has been minimized.

Show comment
Hide comment
@puddlecoded

puddlecoded Feb 22, 2017

10.12.3 Compiled from source => downloaded master. Not sure if the buildings are indestructible or 10000+ hitpoints

puddlecoded commented Feb 22, 2017

10.12.3 Compiled from source => downloaded master. Not sure if the buildings are indestructible or 10000+ hitpoints

@miniupnp

This comment has been minimized.

Show comment
Hide comment
@miniupnp

miniupnp Feb 22, 2017

Contributor

thx

Contributor

miniupnp commented Feb 22, 2017

thx

@svuorela

This comment has been minimized.

Show comment
Hide comment
@svuorela

svuorela Dec 11, 2017

I've seen it with befd661 - they weren't indestructible, but took 20 or so minutes each with quite an army.

svuorela commented Dec 11, 2017

I've seen it with befd661 - they weren't indestructible, but took 20 or so minutes each with quite an army.

@miniupnp

This comment has been minimized.

Show comment
Hide comment
@miniupnp

miniupnp Dec 14, 2017

Contributor

It is possible there is garbage in your scenario files
hitpoints are loaded there :
https://github.com/OpenDUNE/OpenDUNE/blob/master/src/scenario.c#L260

it was modified 6179c08#diff-13fb39c800c305082d53172f62b711ccR422

Contributor

miniupnp commented Dec 14, 2017

It is possible there is garbage in your scenario files
hitpoints are loaded there :
https://github.com/OpenDUNE/OpenDUNE/blob/master/src/scenario.c#L260

it was modified 6179c08#diff-13fb39c800c305082d53172f62b711ccR422

@miniupnp

This comment has been minimized.

Show comment
Hide comment
@miniupnp

miniupnp Dec 14, 2017

Contributor

OK it is that. Some scenario have strange values...

Scenario_Load_Structure ID001 Ordos,Const Yard,8421,936
hitpoints=8421 => 13157
Scenario_Load_Structure ID000 Ordos,Light Fctry,14058,1064
hitpoints=14058 => 19219
Scenario_Load_Structure ID036 Harkonnen,Const Yard,256,3234
hitpoints=256 => 400
Scenario_Load_Structure ID014 Ordos,Windtrap,256,1253
hitpoints=256 => 200
Scenario_Load_Structure ID012 Ordos,Windtrap,256,1255
hitpoints=256 => 200
Scenario_Load_Structure ID010 Ordos,Spice Silo,256,933
hitpoints=256 => 150
Scenario_Load_Structure ID009 Ordos,Refinery,256,1124
hitpoints=256 => 450
Scenario_Load_Structure ID007 Ordos,Barracks,256,1257
hitpoints=256 => 300
Scenario_Load_Structure ID002 Ordos,Outpost,256,1382
hitpoints=256 => 500

Contributor

miniupnp commented Dec 14, 2017

OK it is that. Some scenario have strange values...

Scenario_Load_Structure ID001 Ordos,Const Yard,8421,936
hitpoints=8421 => 13157
Scenario_Load_Structure ID000 Ordos,Light Fctry,14058,1064
hitpoints=14058 => 19219
Scenario_Load_Structure ID036 Harkonnen,Const Yard,256,3234
hitpoints=256 => 400
Scenario_Load_Structure ID014 Ordos,Windtrap,256,1253
hitpoints=256 => 200
Scenario_Load_Structure ID012 Ordos,Windtrap,256,1255
hitpoints=256 => 200
Scenario_Load_Structure ID010 Ordos,Spice Silo,256,933
hitpoints=256 => 150
Scenario_Load_Structure ID009 Ordos,Refinery,256,1124
hitpoints=256 => 450
Scenario_Load_Structure ID007 Ordos,Barracks,256,1257
hitpoints=256 => 300
Scenario_Load_Structure ID002 Ordos,Outpost,256,1382
hitpoints=256 => 500

@miniupnp

This comment has been minimized.

Show comment
Hide comment
@miniupnp

miniupnp Dec 14, 2017

Contributor

That's a kind of bug in One scenario :

/EXTRACT/SCENARIO$ grep ID * |grep -v 256
SCENH006.INI:ID001=Ordos,Const Yard,8421,936
SCENH006.INI:ID000=Ordos,Light Fctry,14058,1064
SCENO001.INI:ID036=Harkonnen,Trooper,199,1488,64,Ambush
SCENO001.INI:ID035=Harkonnen,Trooper,199,1633,64,Ambush
SCENO001.INI:ID034=Harkonnen,Trooper,142,1878,64,Ambush
SCENO001.INI:ID032=Harkonnen,Trooper,199,2090,64,Ambush
SCENO001.INI:ID023=Harkonnen,Trooper,85,2839,64,Ambush
SCENO002.INI:ID037=Harkonnen,Quad,216,1511,160,Area Guard
SCENO002.INI:ID040=Harkonnen,Quad,216,1126,160,Area Guard
SCENO003.INI:ID026=Harkonnen,Trooper,199,2539,64,Area Guard
SCENO003.INI:ID031=Harkonnen,Trooper,142,2341,64,Ambush

Contributor

miniupnp commented Dec 14, 2017

That's a kind of bug in One scenario :

/EXTRACT/SCENARIO$ grep ID * |grep -v 256
SCENH006.INI:ID001=Ordos,Const Yard,8421,936
SCENH006.INI:ID000=Ordos,Light Fctry,14058,1064
SCENO001.INI:ID036=Harkonnen,Trooper,199,1488,64,Ambush
SCENO001.INI:ID035=Harkonnen,Trooper,199,1633,64,Ambush
SCENO001.INI:ID034=Harkonnen,Trooper,142,1878,64,Ambush
SCENO001.INI:ID032=Harkonnen,Trooper,199,2090,64,Ambush
SCENO001.INI:ID023=Harkonnen,Trooper,85,2839,64,Ambush
SCENO002.INI:ID037=Harkonnen,Quad,216,1511,160,Area Guard
SCENO002.INI:ID040=Harkonnen,Quad,216,1126,160,Area Guard
SCENO003.INI:ID026=Harkonnen,Trooper,199,2539,64,Area Guard
SCENO003.INI:ID031=Harkonnen,Trooper,142,2341,64,Ambush

@miniupnp

This comment has been minimized.

Show comment
Hide comment
@miniupnp

miniupnp Dec 14, 2017

Contributor

@TrueBrain as you are the author of the original modification, what do you think ?
We could fix the problem with
if(hitpoints > 256) hitpoints = 256;
as it is meaning less to have more than 100% "life"

Contributor

miniupnp commented Dec 14, 2017

@TrueBrain as you are the author of the original modification, what do you think ?
We could fix the problem with
if(hitpoints > 256) hitpoints = 256;
as it is meaning less to have more than 100% "life"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment