New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an argument to enable/disable table de-nesting #1

Open
DavidGinzberg opened this Issue Nov 15, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@DavidGinzberg
Collaborator

DavidGinzberg commented Nov 15, 2018

As described in source:

...
    #Removes nested tables. for handling the sins of 1990's web pages.
    #TODO: Add an argument to enable/disable table de-nesting
    [t.extract() for t in table.findAll("table")]
    #This would grab all TRs regardless of depth without the above line removing nested tables
    for row in table.findAll('tr'):
...

The table de-nesting hack is currently default behavior. For better backwards compatibility and flexibility it may be better to make it off-by-default and add a flag to enable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment