Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCDS: Report children of additional fields #1080

Closed
jpmckinney opened this issue Nov 14, 2018 · 5 comments
Closed

OCDS: Report children of additional fields #1080

jpmckinney opened this issue Nov 14, 2018 · 5 comments

Comments

@jpmckinney
Copy link

jpmckinney commented Nov 14, 2018

Presently, if a user were to have a typo in a shallow field, like awards or contracts, a single additional field would be reported. Similarly, if a user were to disclose a lot of additional information in new fields that were nested under a new field, only the nesting field would be reported.

This makes it harder to notice cases where a user is disclosing data under additional fields that ought to be disclosed under existing fields.

Instead, it would be preferred to include the child-fields of additional fields in the report.

@kindly
Copy link
Contributor

kindly commented Nov 15, 2018

@jpmckinney this was an intentional decision. Especially considering showing all fields was easier to implement.

The reason why it was done this way was that any spelling mistake on the "shallow field" or on large undeclared extensions, would cause so many additional fields it would make the report unwieldy and would be hard to spot any of the other additional terms.

The compromise would be for any non leaf additional field to report how many fields that are contained within it and give the option to expand to see them.

@jpmckinney
Copy link
Author

The compromise would be for any non leaf additional field to report how many fields that are contained within it and give the option to expand to see them.

This sounds good to me!

@robredpath
Copy link
Member

At the Feb retreat, we discussed making this data available via the cmdline tool / Kingfisher, and potentially adding it to the web version of the DRT as a popup/hidden box.

@jpmckinney
Copy link
Author

On today's call, this was mentioned as a candidate for the Apr-May 2019 sprint.

@jpmckinney
Copy link
Author

This was marked as done in sprint document: https://docs.google.com/document/d/1zaip5-lG8_RpQcYlGVAE-8fvu-_JeJCoVR-KTikmRDg/edit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants