Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

528 codelist 529 extension merge #609

Merged
merged 67 commits into from Mar 20, 2017
Merged

528 codelist 529 extension merge #609

merged 67 commits into from Mar 20, 2017

Conversation

kindly
Copy link
Contributor

@kindly kindly commented Mar 20, 2017 •
edited by Bjwebb

A merge of #606 and #609 to be merged into master in one pull request, so we can reuse the known good merge commit.

@edugomez
[#529] A bit of (trivial) code tidying up
6319d47
@edugomez
[#529] Add Schema class to lib
064e4d8
@edugomez
[#529] Add json-merge-patch and cached-property to requirements
1363289
@edugomez
[#529] Schema class: add extension methods
11f453b
@edugomez
[#529] Schema._schema_data: use urljoin to build url
a805c83
@edugomez
[#529] Schema.get_extended_schema_data: check for errors when extendi…
0034275 
…ng schema
@edugomez
[#529] Schema class: replace all schema_name, etc ... with package_na…
22979cb 
…me, etc...
@edugomez
[#529] Schema class: add release_url cached_property
6837dd3
@edugomez
[#529] Schema class: add _release_text cached_property
7409955
@edugomez
[#529] Schema.extensions: get extension from the schema release-packa…
7de1d54 
…ge text
@edugomez
[#529] Schema.extensions_errors: add extension errors with short mess…
afeb2d0 
…ages
@edugomez
[#529] Schema class: rename get_extended_release_data as get_release_…
c204376 
…data plus refactor
@edugomez
[#529] Schema class: get rid of _deref_release_data method
2253377
@edugomez
[#529] Schema class: add get_package_data
e5f60cb
@edugomez
[#529] Schema.get_package_data: fix bug failing to serialize JSON'
c75f3d7
@edugomez
[#529] Schema class: add user_data parameter to constructor
056bca7
@edugomez
[#529] Schema class: modify constructor to build properties from eith…
74770d1 
…er user data or defaults
@edugomez
[#529] lib.common: some (trivial) import order tidying up
5527060
@edugomez
[#529] cove.tests: some (trivial) import order tidying up
d4befa0
@edugomez
[#529] Schema class: add test for constructor
02e0948
@edugomez
[#529] Schema class: add apply_extension method
0a7b424
@edugomez
[#529] Schema class: add get_release_schema_temp_filename method
1a2f47b
@edugomez
[#529] cove.views: import order tidying up
2e09e85
@edugomez
[#529] tests: add test for extensions in Schema class
7b81747
@edugomez
[#529] tests: add test for extensions in Schema class
eb87055
@edugomez
[#529] Schema class: add version kwarg to constructor
46e94eb
@edugomez
[#529] Schema class: change name of property package_host to schema_host
96858ed
@edugomez
[#529] Schema class: replace get_release_schema_temp_filename with (@…
778d8e0 
…Property)release_schema_temp_file
@edugomez
[#529] views.explore: refactor to use Schema class
ec491f7
@edugomez
[#529] Some (trivial) layout changes for long strings
8bfd1d7
edugomez and others added 27 commits March 6, 2017 15:56
@edugomez
[#529] Schema class: register all Request exceptions for extensions a…
4794627 
…s "Fetching failed"
@edugomez
[#529] converters: pass full schema url to converters'
e0665cd
@edugomez
[#529] Schema class: add method to create extended schema file replac…
6114469 
…ing Schema.release_schema_temp_file
@edugomez
[#526] explore view: refactor logic of instantiating schema object
fc7a0bc
@edugomez
[#529] Schema class: rename version argument as select_version
683787a
@edugomez
[#529] Schema360: Add classes Schema360,SchemaMixin and rename Schema…
9f92658 
… as SchemaOCDS
@edugomez
[#529] explore view: create independent explore_360, explore_ocds and…
1869a19 
… render_explore
@edugomez
[#529] Schema360: add unittest
3f237b0
@edugomez
[#529] Pass schema_obj as argument to functions instead of building s…
0e4cbb3 
…chema_url + schema_name everywhere
@edugomez
[#529] SchemaOCDS-360: replace get_schema_data and get_schema_fields …
974db45 
…with SchemaOCDS-360 methods
@edugomez
[#529] requirements: use older selenium version in requirements_dev.txt
9b936bd
@edugomez
[#529] Schema Mixin: refactor to add default methods
518922b
@edugomez
[#529] explore_ocds_base.html: add schema extensions
7f43956
@edugomez
[#529] explore_ocds view: refactor version application
ec97210
@edugomez
[#529] Move download glyphicons outside <a></a>
962c1e1
@edugomez
[#529] fts tests: add tests for extensions
191840f
@kindly
[#528] Change copy add link to csv viewer.
98d0c91
@edugomez
[#529] tests: add tests for SchemaOCDS
a2a0f04
@edugomez
[#529] SchemaOCDS: add docstring to constructor
8ba3f24
@kindly
[#528] Whilst iterating do not require properties to always in the sc…
8c581e2 
…hema.
@edugomez
[#529] SchemaOCDS: reuse and do not rewrite the extended file json is…
11ba0f2 
… is already there
@edugomez
[#529] SchemaOCDS: add record_package methods
d1e0338
@edugomez
#[529] CustomRefResolver: modify to accept a schema file argument
c546fc1
@edugomez
[#529] extensions: display more user friendly OCDS extension info in …
caa7c5b 
…explore page
@edugomez
[#529] SchemaOCDS: add record_package methods
bae901c
@edugomez
[#529] Schema classes: rename references to package_schema and record…
5eabe3f 
…_schema as release_pkg and record_pkg
@edugomez
Merge branch '529-add-OCDS-extension-support' into 528-codelist-529-e…
e997d15 
…xtension-merge
@kindly kindly merged commit ab71743 into master Mar 20, 2017
@robredpath robredpath deleted the 528-codelist-529-extension-merge branch May 31, 2017 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bjwebb Bjwebb Bjwebb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kindly @Bjwebb @edugomez