D4.9: In-place computation in active documents (context/computation) #97

Closed
minrk opened this Issue Sep 8, 2015 · 51 comments

Comments

Projects
None yet
5 participants
@minrk
Contributor

minrk commented Sep 8, 2015

  • WP4: User Interfaces
  • Lead Institution: Jacobs University Bremen
  • Due: 2017-02-28 (month 18)
  • Nature: Demonstrator
  • Task: T4.6 (#74): Structured documents
  • Proposal: p. 48
  • Final report

One of the most prominent features of a virtual research environment (VRE) is a unified user interface (UI). There are two complementary approaches that can serve as a basis for OpenDreamKit's mathematical VRE UI: computational notebooks and active structured documents. The former allows for mathematical text around the computation cells of a real-eval-print loop of a mathematical computational system and the latter makes semantically annotated documents active.

In D4.2 “Active/Structured Documents Requirements and existing Solutions” (#91) we reported on two systems in the OpenDreamKit project which follow respectively those two approaches: Jupyter -- a notebook server for various computational systems -- and MathHub.info -- a platform for active mathematical documents. We identified commonalities and differences and developed a vision for integrating their functionalities.

As a first step into this direction we explore in this deliverable the requirements of integrating in-situ (i.e. in-document) computation – a forte and indeed the raison-d'être of notebooks – into conventional, narrative-structured mathematical documents. We present, analyze, and classify examples for in-situ computation and explore -- in particular in a MathHub.info based prototype -- how the active documents technology has to be extended to accommodate this functionality as a semantic service.

@minrk minrk added this to the D4.8 milestone Sep 8, 2015

@minrk minrk self-assigned this Nov 3, 2015

@nthiery nthiery modified the milestones: Month 18: 2017-02-28, D4.8 Mar 22, 2016

@nthiery nthiery assigned kohlhase and unassigned minrk Jun 30, 2016

@bpilorget

This comment has been minimized.

Show comment
Hide comment
@bpilorget

bpilorget Nov 21, 2016

Contributor

@minrk (WP leader), and I see @kohlhase was assigned?
This deliverable is due for February 2017

Contributor

bpilorget commented Nov 21, 2016

@minrk (WP leader), and I see @kohlhase was assigned?
This deliverable is due for February 2017

@bpilorget bpilorget changed the title from D4.8: In-place computation in active documents (context/computation) to D4.9: In-place computation in active documents (context/computation) Dec 16, 2016

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Dec 19, 2016

Contributor

@kohlhase what needs to be done to finish this deliverable for February?

Contributor

minrk commented Dec 19, 2016

@kohlhase what needs to be done to finish this deliverable for February?

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Jan 9, 2017

Member

(begin internal note)
Originally, we wanted to base this on jupyther interaction, but I think that this is probably unrealistic. I guess what we should do is to use the SCSCP connection to GAP and embed that into the generated documents.
(end internal)
@tkw1536

Member

kohlhase commented Jan 9, 2017

(begin internal note)
Originally, we wanted to base this on jupyther interaction, but I think that this is probably unrealistic. I guess what we should do is to use the SCSCP connection to GAP and embed that into the generated documents.
(end internal)
@tkw1536

@nthiery

This comment has been minimized.

Show comment
Hide comment
@nthiery

nthiery Feb 6, 2017

Contributor

Dear M18 deliverable leaders,

Just a reminder that reports are due for mid-february, to buy us some time for proofreading, feedback, and final submission before February 28th. See our README for details on the process.

In practice, I'll be offline February 12-19, and the week right after will be pretty busy. Therefore, it would be helpful if a first draft could be available sometime this week, so that I can have a head start reviewing it.

Thanks in advance!

Contributor

nthiery commented Feb 6, 2017

Dear M18 deliverable leaders,

Just a reminder that reports are due for mid-february, to buy us some time for proofreading, feedback, and final submission before February 28th. See our README for details on the process.

In practice, I'll be offline February 12-19, and the week right after will be pretty busy. Therefore, it would be helpful if a first draft could be available sometime this week, so that I can have a head start reviewing it.

Thanks in advance!

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 6, 2017

Member

I am just seeing that this is called D4.9 in the title, but in the proposal, it is D4.8. It seems that there are more such errors in the titles.
Should we (manually) correct the titles?

Member

kohlhase commented Feb 6, 2017

I am just seeing that this is called D4.9 in the title, but in the proposal, it is D4.8. It seems that there are more such errors in the titles.
Should we (manually) correct the titles?

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 6, 2017

Member

I just want to point out that there is already a draft in the repository WP4/D4.8, it is not complete yet, but gives you a hint of where it is heading.

Member

kohlhase commented Feb 6, 2017

I just want to point out that there is already a draft in the repository WP4/D4.8, it is not complete yet, but gives you a hint of where it is heading.

@nthiery

This comment has been minimized.

Show comment
Hide comment
@nthiery

nthiery Feb 6, 2017

Contributor
Contributor

nthiery commented Feb 6, 2017

@nthiery

This comment has been minimized.

Show comment
Hide comment
@nthiery

nthiery Feb 6, 2017

Contributor
Contributor

nthiery commented Feb 6, 2017

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 7, 2017

Member

This is also important for the naming of the subdirectories of the WP? directories in the repository, they should be consistent with the grant agreement as well.

Member

kohlhase commented Feb 7, 2017

This is also important for the naming of the subdirectories of the WP? directories in the repository, they should be consistent with the grant agreement as well.

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 7, 2017

Member

In this case I am using D4.8 since that is is in the proposal.

Member

kohlhase commented Feb 7, 2017

In this case I am using D4.8 since that is is in the proposal.

@bpilorget

This comment has been minimized.

Show comment
Hide comment
@bpilorget

bpilorget Feb 7, 2017

Contributor

@nthiery and @kohlhase After having checked the EU participant portal, the names of D4.8 and D4.9 an the right ones on github so no need to change anything here.
capture

Contributor

bpilorget commented Feb 7, 2017

@nthiery and @kohlhase After having checked the EU participant portal, the names of D4.8 and D4.9 an the right ones on github so no need to change anything here.
capture

@bpilorget

This comment has been minimized.

Show comment
Hide comment
@bpilorget

bpilorget Feb 7, 2017

Contributor

And in the Proposal I have file UserInterfaces.tex, the two deliverables being discussed refer to the right issue. And I also checked the official Proposal on the EU website, and the signed version after the 1st amendment shows that the github issues are right. But I noticed that in draft versions of the proposal for the 1st amendment the 2 deliverables names were confused.

I pushed the latest Description of the action pdf document so that you can see it.

Best

Contributor

bpilorget commented Feb 7, 2017

And in the Proposal I have file UserInterfaces.tex, the two deliverables being discussed refer to the right issue. And I also checked the official Proposal on the EU website, and the signed version after the 1st amendment shows that the github issues are right. But I noticed that in draft versions of the proposal for the 1st amendment the 2 deliverables names were confused.

I pushed the latest Description of the action pdf document so that you can see it.

Best

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 7, 2017

Member

I have seen the rename (got me a bit of a hard merge from my fork). BUT the proposal on ODK.org still shows me the 4.8. Should we not update that?

Member

kohlhase commented Feb 7, 2017

I have seen the rename (got me a bit of a hard merge from my fork). BUT the proposal on ODK.org still shows me the 4.8. Should we not update that?

@bpilorget

This comment has been minimized.

Show comment
Hide comment
@bpilorget

bpilorget Feb 7, 2017

Contributor

Sorry for the not so smooth merge... Yes, we'll update the proposal. Maybe the rename was a human mistake at some point but now what counts is the official document.

Contributor

bpilorget commented Feb 7, 2017

Sorry for the not so smooth merge... Yes, we'll update the proposal. Maybe the rename was a human mistake at some point but now what counts is the official document.

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 7, 2017

Member

all is fine as long as we resolve the inconsistency before it really bites us.

Member

kohlhase commented Feb 7, 2017

all is fine as long as we resolve the inconsistency before it really bites us.

@nthiery

This comment has been minimized.

Show comment
Hide comment
@nthiery

nthiery Feb 8, 2017

Contributor

Hi,
I am missing the calbf style file and docicon tikzlibrary to compile the report. Is this part of a typical texlive distribution (I believe I have texlive-all here)? Or should they be added to the repo?

Cheers,
Nicolas

Contributor

nthiery commented Feb 8, 2017

Hi,
I am missing the calbf style file and docicon tikzlibrary to compile the report. Is this part of a typical texlive distribution (I believe I have texlive-all here)? Or should they be added to the repo?

Cheers,
Nicolas

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 9, 2017

Member

sorry, I had already added them on the KWARC fork, but had not pushed. Now they should be there.
the styles are not "official", calbf is just a convenience macros set; docicon might be useful for anyone who uses tikz (it provies a document icond node).

Member

kohlhase commented Feb 9, 2017

sorry, I had already added them on the KWARC fork, but had not pushed. Now they should be there.
the styles are not "official", calbf is just a convenience macros set; docicon might be useful for anyone who uses tikz (it provies a document icond node).

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 9, 2017

Member

BTW, the report and implementation are on track, @tkw1536 is working on that as we speak.

Member

kohlhase commented Feb 9, 2017

BTW, the report and implementation are on track, @tkw1536 is working on that as we speak.

@nthiery

This comment has been minimized.

Show comment
Hide comment
@nthiery

nthiery Feb 9, 2017

Contributor
Contributor

nthiery commented Feb 9, 2017

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 9, 2017

Member

Yes, we'll update the proposal.

@nthiery @bpilorget I think we should do that very soon, since the generated titles are wrong otherwise.

Member

kohlhase commented Feb 9, 2017

Yes, we'll update the proposal.

@nthiery @bpilorget I think we should do that very soon, since the generated titles are wrong otherwise.

@bpilorget

This comment has been minimized.

Show comment
Hide comment
@bpilorget

bpilorget Feb 9, 2017

Contributor

As far as I understand the proposal files, the generated titles are right. What I need to update is the Grant Agreement PDF version on the website.

Contributor

bpilorget commented Feb 9, 2017

As far as I understand the proposal files, the generated titles are right. What I need to update is the Grant Agreement PDF version on the website.

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 9, 2017

Member

no, that is not true, the reports have the line

\deliverable{UI}{adcomp}

which reads proposal.pdata and in this case, this contains that the deliverable UI:adcomp is D4.8, hence the wrong title of my report :-(

Member

kohlhase commented Feb 9, 2017

no, that is not true, the reports have the line

\deliverable{UI}{adcomp}

which reads proposal.pdata and in this case, this contains that the deliverable UI:adcomp is D4.8, hence the wrong title of my report :-(

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 9, 2017

Member

and I suspect that this is true for other deliverables as well (i.e at least all D4.y, where y>=9).

Member

kohlhase commented Feb 9, 2017

and I suspect that this is true for other deliverables as well (i.e at least all D4.y, where y>=9).

@bpilorget

This comment has been minimized.

Show comment
Hide comment
@bpilorget

bpilorget Feb 9, 2017

Contributor

I right now don't know how to modify (nor open) the proposal.pdata document.
If you know, please have a go. I need to update my tools next week with Erik. I currently cannot create a pdf document from the latex files. So this will have to wait Monday or Tuesday.

Contributor

bpilorget commented Feb 9, 2017

I right now don't know how to modify (nor open) the proposal.pdata document.
If you know, please have a go. I need to update my tools next week with Erik. I currently cannot create a pdf document from the latex files. So this will have to wait Monday or Tuesday.

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 9, 2017

Member

I think that @nthiery or I should have a look at this.

Member

kohlhase commented Feb 9, 2017

I think that @nthiery or I should have a look at this.

@nthiery

This comment has been minimized.

Show comment
Hide comment
@nthiery

nthiery Feb 9, 2017

Contributor
Contributor

nthiery commented Feb 9, 2017

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 9, 2017

Member

unless you are quicker :-)

not likely, I have my last course tomorrow, and it is not prepared yet. Sorry.

Member

kohlhase commented Feb 9, 2017

unless you are quicker :-)

not likely, I have my last course tomorrow, and it is not prepared yet. Sorry.

@nthiery

This comment has been minimized.

Show comment
Hide comment
@nthiery

nthiery Feb 10, 2017

Contributor

Hi @kohlhase,
I am recompiling the proposal. I just fixed one typo in the style file which caused trac issue numbers not be included in the pdata (7ace63c), and a trivial one in a bib file of yours (4a270f9).

There remains one issue that you would be quicker to track and fix: after a make final on my machine, the task titles currently do not appear in final.pdf! See e.g. T1.1 p. 44.

This ends up changing the page numbering, so I did not commit the new final.pdata ...

Contributor

nthiery commented Feb 10, 2017

Hi @kohlhase,
I am recompiling the proposal. I just fixed one typo in the style file which caused trac issue numbers not be included in the pdata (7ace63c), and a trivial one in a bib file of yours (4a270f9).

There remains one issue that you would be quicker to track and fix: after a make final on my machine, the task titles currently do not appear in final.pdf! See e.g. T1.1 p. 44.

This ends up changing the page numbering, so I did not commit the new final.pdata ...

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 10, 2017

Member

did you push?

Member

kohlhase commented Feb 10, 2017

did you push?

@nthiery

This comment has been minimized.

Show comment
Hide comment
@nthiery

nthiery Feb 10, 2017

Contributor
Contributor

nthiery commented Feb 10, 2017

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 10, 2017

Member

I have fixed the titles, but unfortunately, I am still getting that the in-place computation is D4.8 there.
I am not sure where this discrepancy may come from. Can you post the deliverables list of the EU?
I fear that we will need to compare final.pdf to that list manually

Member

kohlhase commented Feb 10, 2017

I have fixed the titles, but unfortunately, I am still getting that the in-place computation is D4.8 there.
I am not sure where this discrepancy may come from. Can you post the deliverables list of the EU?
I fear that we will need to compare final.pdf to that list manually

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 10, 2017

Member

Ah, I think I understand what is happening. We just have to switch the deliverables D4.8 and D4.9 in the proposal source, and then things should line up again. Let me try this and see if that works.

Member

kohlhase commented Feb 10, 2017

Ah, I think I understand what is happening. We just have to switch the deliverables D4.8 and D4.9 in the proposal source, and then things should line up again. Let me try this and see if that works.

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 11, 2017

Member

OK, this seems to indeed solve the inconsistency.

Member

kohlhase commented Feb 11, 2017

OK, this seems to indeed solve the inconsistency.

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 11, 2017

Member

We can go back to real work on the report now.

Member

kohlhase commented Feb 11, 2017

We can go back to real work on the report now.

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 12, 2017

Member

I have a relatively feature complete version of the report. @tkw1536 will work on the implementation some more (so that it conforms more to the specification), we will have this demoable for the review.
The next steps are to let this rest a bit, reread, and declare victory.

Member

kohlhase commented Feb 12, 2017

I have a relatively feature complete version of the report. @tkw1536 will work on the implementation some more (so that it conforms more to the specification), we will have this demoable for the review.
The next steps are to let this rest a bit, reread, and declare victory.

@kohlhase

This comment has been minimized.

Show comment
Hide comment
@kohlhase

kohlhase Feb 16, 2017

Member

The next steps are to let this rest a bit, reread, and declare victory.

I did that, and had to do a bit more for real feature-completeness. The only work that needs to be done is in section 4, which @tkw1536 will do.

So (as with D4.3, see #92) it would be good if Nicolas or Benoit could have a look at this deliverable and tell me if something else needs to be done before I travel.

Member

kohlhase commented Feb 16, 2017

The next steps are to let this rest a bit, reread, and declare victory.

I did that, and had to do a bit more for real feature-completeness. The only work that needs to be done is in section 4, which @tkw1536 will do.

So (as with D4.3, see #92) it would be good if Nicolas or Benoit could have a look at this deliverable and tell me if something else needs to be done before I travel.

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Feb 16, 2017

Contributor

Thanks, @kohlhase!

Contributor

minrk commented Feb 16, 2017

Thanks, @kohlhase!

@nthiery

This comment has been minimized.

Show comment
Hide comment
@nthiery

nthiery Feb 23, 2017

Contributor

Hi,

I just browsed through the report. It looks good, thanks!

I fixed some typos. Note that I allowed myself to use \delivref rather than \cite to refer to other deliverables, for consistency with what we have done in other reports.

Things that remain to do:

  • Detailed proofreading; there certainly are quite a few remaining typos. @minrk maybe?
  • Writing down an abstract in the github description, giving a brief overview of what the deliverable is about, how it fits in the greater ODK picture and what was achieved. Plausibly, most of the required pieces of language can be taken from the current introduction and conclusion; so that should not be too much work. @tkw1536: could you have a first shot at it?

Cheers,
Nicolas

Contributor

nthiery commented Feb 23, 2017

Hi,

I just browsed through the report. It looks good, thanks!

I fixed some typos. Note that I allowed myself to use \delivref rather than \cite to refer to other deliverables, for consistency with what we have done in other reports.

Things that remain to do:

  • Detailed proofreading; there certainly are quite a few remaining typos. @minrk maybe?
  • Writing down an abstract in the github description, giving a brief overview of what the deliverable is about, how it fits in the greater ODK picture and what was achieved. Plausibly, most of the required pieces of language can be taken from the current introduction and conclusion; so that should not be too much work. @tkw1536: could you have a first shot at it?

Cheers,
Nicolas

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Feb 23, 2017

Contributor

@nthiery I'll give it a proofreading pass.

Contributor

minrk commented Feb 23, 2017

@nthiery I'll give it a proofreading pass.

@tkw1536

This comment has been minimized.

Show comment
Hide comment
@tkw1536

tkw1536 Feb 23, 2017

Contributor

@nthiery Finalising this report is on my list for tomorrow. In section four I in particular still have to describe a demo I have been working on as well as replace some sketches with actual screenshots.

Contributor

tkw1536 commented Feb 23, 2017

@nthiery Finalising this report is on my list for tomorrow. In section four I in particular still have to describe a demo I have been working on as well as replace some sketches with actual screenshots.

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Feb 24, 2017

Contributor

I did a proofreading pass, excluding section four to avoid conflicts.

Contributor

minrk commented Feb 24, 2017

I did a proofreading pass, excluding section four to avoid conflicts.

@tkw1536

This comment has been minimized.

Show comment
Hide comment
@tkw1536

tkw1536 Feb 24, 2017

Contributor

@nthiery I have just pushed some work on section 4 as well as all over the report. There also is a first version of the abstract (committed separately as abstract.tex) which I have just put into the description of this issue. Content-wise the report is done from my side, but I still want to read through it once more over the weekend. Also I still have to fix a minor issue with regards to one of the linked demos.

Contributor

tkw1536 commented Feb 24, 2017

@nthiery I have just pushed some work on section 4 as well as all over the report. There also is a first version of the abstract (committed separately as abstract.tex) which I have just put into the description of this issue. Content-wise the report is done from my side, but I still want to read through it once more over the weekend. Also I still have to fix a minor issue with regards to one of the linked demos.

@tkw1536

This comment has been minimized.

Show comment
Hide comment
@tkw1536

tkw1536 Feb 25, 2017

Contributor

OK, I have gone over it once more and have fixed a bunch of typos. From my side the report is now completely done and ready to be submitted with the exception of one thing: Do I include the abstract written above into the document itself? If so, how?

Contributor

tkw1536 commented Feb 25, 2017

OK, I have gone over it once more and have fixed a bunch of typos. From my side the report is now completely done and ready to be submitted with the exception of one thing: Do I include the abstract written above into the document itself? If so, how?

@nthiery

This comment has been minimized.

Show comment
Hide comment
@nthiery

nthiery Feb 26, 2017

Contributor

I updated the abstract above to try to give some more context to the reviewers (please proofread/edit! you know better what this deliverable is about), and integrated into the report by running:

rm WP4/D4.9/report.pdf WP4/D4.9/github-issue-description.*
make WP4/D4.9/report.pdf 

Reading the report now!

Contributor

nthiery commented Feb 26, 2017

I updated the abstract above to try to give some more context to the reviewers (please proofread/edit! you know better what this deliverable is about), and integrated into the report by running:

rm WP4/D4.9/report.pdf WP4/D4.9/github-issue-description.*
make WP4/D4.9/report.pdf 

Reading the report now!

@nthiery

This comment has been minimized.

Show comment
Hide comment
@nthiery

nthiery Feb 26, 2017

Contributor

Two minor things, and then it's indeed good to go:

  • Maybe refer to Figure 5 in 2.1? Maybe even put the picture in 2.1 to make things right away more concrete?
  • For consistency with our other documents, please refer to other deliverables by using e.g. \delivref{UI}{mathhub-editing} or its \longdelivref counterpart rather than with citations. To find the deliverable labels, I usually search through /Proposal/final.pdata.

Thanks!

Contributor

nthiery commented Feb 26, 2017

Two minor things, and then it's indeed good to go:

  • Maybe refer to Figure 5 in 2.1? Maybe even put the picture in 2.1 to make things right away more concrete?
  • For consistency with our other documents, please refer to other deliverables by using e.g. \delivref{UI}{mathhub-editing} or its \longdelivref counterpart rather than with citations. To find the deliverable labels, I usually search through /Proposal/final.pdata.

Thanks!

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Feb 27, 2017

Contributor

I updated it to use delivref where appropriate. I'll leave it to the authors to decide what to do about the Figure, if anything.

Contributor

minrk commented Feb 27, 2017

I updated it to use delivref where appropriate. I'll leave it to the authors to decide what to do about the Figure, if anything.

@tkw1536

This comment has been minimized.

Show comment
Hide comment
@tkw1536

tkw1536 Feb 27, 2017

Contributor

Concerning moving Figure 5, I think it is better to leave it as is. We first introduce some of the possible applications (in section 2), then describe our approach (section 3) and then only in section 4 we show what we have concretely achieved. Moving Figure 5 away from section 3 might make it more concrete in the beginning, but could also be interpreted as the screenshot showing something that already existed before.

Contributor

tkw1536 commented Feb 27, 2017

Concerning moving Figure 5, I think it is better to leave it as is. We first introduce some of the possible applications (in section 2), then describe our approach (section 3) and then only in section 4 we show what we have concretely achieved. Moving Figure 5 away from section 3 might make it more concrete in the beginning, but could also be interpreted as the screenshot showing something that already existed before.

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Feb 27, 2017

Contributor

@tkw1536 thanks! In that case, I think this report is ready to submit.

Contributor

minrk commented Feb 27, 2017

@tkw1536 thanks! In that case, I think this report is ready to submit.

@nthiery

This comment has been minimized.

Show comment
Hide comment
@nthiery

nthiery Feb 27, 2017

Contributor

Ok. On it!

Contributor

nthiery commented Feb 27, 2017

Ok. On it!

@nthiery

This comment has been minimized.

Show comment
Hide comment
@nthiery

nthiery Feb 27, 2017

Contributor

I allowed myself some tweaking of the figures and listings for better readability.

Contributor

nthiery commented Feb 27, 2017

I allowed myself some tweaking of the figures and listings for better readability.

@nthiery

This comment has been minimized.

Show comment
Hide comment
@nthiery

nthiery Feb 27, 2017

Contributor

Submitted!
Thanks and congratulations @tkw1536, @kohlhase for a nice deliverable and @minrk for the help!

Contributor

nthiery commented Feb 27, 2017

Submitted!
Thanks and congratulations @tkw1536, @kohlhase for a nice deliverable and @minrk for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment