Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When EXIF has no GPS, GSD not correctly calculated #1065

Closed
smathermather opened this issue Jan 21, 2020 · 0 comments
Closed

When EXIF has no GPS, GSD not correctly calculated #1065

smathermather opened this issue Jan 21, 2020 · 0 comments
Labels
bug

Comments

@smathermather
Copy link
Contributor

@smathermather smathermather commented Jan 21, 2020

When EXIF has no GPS, GSD not correctly calculated. The offending line is
https://github.com/OpenDroneMap/ODM/blob/master/opendm/gsd.py#L117

as the check is only for the GPS DOP value, without a second check as to whether there are GCPs.

How did you install OpenDroneMap? (Docker, natively, ...)?

Docker

What's your browser and operating system? (Copy/paste the output of https://www.whatismybrowser.com/)

Brave, latest

What is the problem?

See above

What should be the expected behavior? If this is a feature request, please describe in detail the changes you think should be made to the code, citing files and lines where changes should be made, if possible.

See above

How can we reproduce this? (What steps did you do to trigger the problem? What parameters are you using for processing? If possible please include a copy of your dataset uploaded on Google Drive or Dropbox. Be detailed)

Run with dataset with no GPS in exif but with GCP file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.