New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP interface integration #37

Closed
pierotofy opened this Issue Oct 25, 2016 · 29 comments

Comments

Projects
None yet
10 participants
@pierotofy
Member

pierotofy commented Oct 25, 2016

I currently skipped the parts of code to handle GCP files. This will need to be added at some point.

@smathermather

This comment has been minimized.

Show comment
Hide comment
@smathermather

smathermather Oct 27, 2016

Contributor

@mojodna will be working on an interface interface for GCP creation in POSM soon.

Contributor

smathermather commented Oct 27, 2016

@mojodna will be working on an interface interface for GCP creation in POSM soon.

@spatialsteve

This comment has been minimized.

Show comment
Hide comment
@spatialsteve

spatialsteve Feb 17, 2017

FYI I am working on a quicker and easier way to create a GCP file for ODM, would this be the best place to share my progress?

spatialsteve commented Feb 17, 2017

FYI I am working on a quicker and easier way to create a GCP file for ODM, would this be the best place to share my progress?

@pierotofy

This comment has been minimized.

Show comment
Hide comment
@pierotofy

pierotofy Feb 17, 2017

Member

Absolutely! 😄

Member

pierotofy commented Feb 17, 2017

Absolutely! 😄

@spatialsteve

This comment has been minimized.

Show comment
Hide comment
@spatialsteve

spatialsteve Feb 17, 2017

Great! I'll be sure to post here :-)

spatialsteve commented Feb 17, 2017

Great! I'll be sure to post here :-)

@smathermather

This comment has been minimized.

Show comment
Hide comment
@smathermather

smathermather Feb 17, 2017

Contributor

Excellent! How far in are you? We do have a project in progress to do just this. Depending on where you are in the process, maybe it'd help for us to share too... .

Contributor

smathermather commented Feb 17, 2017

Excellent! How far in are you? We do have a project in progress to do just this. Depending on where you are in the process, maybe it'd help for us to share too... .

@spatialsteve

This comment has been minimized.

Show comment
Hide comment
@spatialsteve

spatialsteve Feb 17, 2017

At present it is just a concept we are working on, really just aiming initially at making it easier to create the gcp text file, as far as deep integration with the WEbODM workflow, I am not sure how the GCP are currently used. If they are used at the start of the process to increase the accuracy of all processing then what I have conceptualised would work well.

I have some ideas for the logic too but yet to fully flesh it out. This is a wireframe for reference. You will note from some of the design that it is for just creating the txt file at this stage.

screen shot 2017-02-18 at 8 44 01 am

spatialsteve commented Feb 17, 2017

At present it is just a concept we are working on, really just aiming initially at making it easier to create the gcp text file, as far as deep integration with the WEbODM workflow, I am not sure how the GCP are currently used. If they are used at the start of the process to increase the accuracy of all processing then what I have conceptualised would work well.

I have some ideas for the logic too but yet to fully flesh it out. This is a wireframe for reference. You will note from some of the design that it is for just creating the txt file at this stage.

screen shot 2017-02-18 at 8 44 01 am

@smathermather

This comment has been minimized.

Show comment
Hide comment
@smathermather

smathermather Feb 20, 2017

Contributor

Excellent. We'll work on releasing what we have so far as soon as possible.

Contributor

smathermather commented Feb 20, 2017

Excellent. We'll work on releasing what we have so far as soon as possible.

@smathermather

This comment has been minimized.

Show comment
Hide comment
@smathermather

smathermather Feb 22, 2017

Contributor

Ok, it is now opened up, @spatialsteve:
https://github.com/stamen/gcpi

Feedback very welcome. I'd be interested to know how it compares with your vision.

Contributor

smathermather commented Feb 22, 2017

Ok, it is now opened up, @spatialsteve:
https://github.com/stamen/gcpi

Feedback very welcome. I'd be interested to know how it compares with your vision.

@spatialsteve

This comment has been minimized.

Show comment
Hide comment
@spatialsteve

spatialsteve Feb 22, 2017

Great @smathermather I'll take a look - just heading out to capture sunrise footage ;-) thanks for sharing.

spatialsteve commented Feb 22, 2017

Great @smathermather I'll take a look - just heading out to capture sunrise footage ;-) thanks for sharing.

@byezy

This comment has been minimized.

Show comment
Hide comment
@byezy

byezy Apr 11, 2017

Great work guys... so is it the case now that ODM cannot utilise GCPs during processing? I would be very interested in knowing if/when this is planned, and also would happy to do some testing of this functionality as I have access to some commercial software against which to compare results...(if that would help at all). Cheers

byezy commented Apr 11, 2017

Great work guys... so is it the case now that ODM cannot utilise GCPs during processing? I would be very interested in knowing if/when this is planned, and also would happy to do some testing of this functionality as I have access to some commercial software against which to compare results...(if that would help at all). Cheers

@pierotofy

This comment has been minimized.

Show comment
Hide comment
@pierotofy

pierotofy Apr 11, 2017

Member

WebODM doesn't support GCPs yet, ODM and node-OpenDroneMap do.

Member

pierotofy commented Apr 11, 2017

WebODM doesn't support GCPs yet, ODM and node-OpenDroneMap do.

@smathermather

This comment has been minimized.

Show comment
Hide comment
@smathermather

smathermather Apr 11, 2017

Contributor

@pierotofy -- when you get a chance, we have some good updates to https://github.com/stamen/gcpi .

Contributor

smathermather commented Apr 11, 2017

@pierotofy -- when you get a chance, we have some good updates to https://github.com/stamen/gcpi .

@smathermather

This comment has been minimized.

Show comment
Hide comment
@smathermather

smathermather Apr 11, 2017

Contributor

Oops. looks like updates haven't been pushed yet. Disregard for the time being @pierotofy.

Contributor

smathermather commented Apr 11, 2017

Oops. looks like updates haven't been pushed yet. Disregard for the time being @pierotofy.

@pierotofy

This comment has been minimized.

Show comment
Hide comment
@pierotofy

pierotofy Apr 13, 2017

Member

Bummer, I was hoping to start working on this next.

Member

pierotofy commented Apr 13, 2017

Bummer, I was hoping to start working on this next.

@smathermather

This comment has been minimized.

Show comment
Hide comment
@smathermather

smathermather Apr 15, 2017

Contributor

Just bugged to have it pushed to the repo.

Contributor

smathermather commented Apr 15, 2017

Just bugged to have it pushed to the repo.

@pierotofy

This comment has been minimized.

Show comment
Hide comment
@pierotofy

pierotofy May 15, 2017

Member

We now have GCP support via txt file upload (thanks to @gkconsulting ), the GCP interface integration will follow.

Member

pierotofy commented May 15, 2017

We now have GCP support via txt file upload (thanks to @gkconsulting ), the GCP interface integration will follow.

@pierotofy pierotofy changed the title from GCP file support to GCP interface integration May 15, 2017

@LeneFischer

This comment has been minimized.

Show comment
Hide comment
@LeneFischer

LeneFischer Aug 8, 2017

Any news about GCP interface integration. Is there a link to read more about creating GCP ?

LeneFischer commented Aug 8, 2017

Any news about GCP interface integration. Is there a link to read more about creating GCP ?

@pierotofy

This comment has been minimized.

Show comment
Hide comment
@pierotofy

pierotofy Aug 8, 2017

Member

We haven't had time to work further on the GCP interface yet, but it's quite high up in the priority list. Some links to check: https://github.com/OpenDroneMap/OpenDroneMap/wiki/Running-OpenDroneMap#running-odm-with-ground-control and https://smathermather.com/2015/03/01/opendronemap-gcp-file-format/

Member

pierotofy commented Aug 8, 2017

We haven't had time to work further on the GCP interface yet, but it's quite high up in the priority list. Some links to check: https://github.com/OpenDroneMap/OpenDroneMap/wiki/Running-OpenDroneMap#running-odm-with-ground-control and https://smathermather.com/2015/03/01/opendronemap-gcp-file-format/

@dani2007

This comment has been minimized.

Show comment
Hide comment
@dani2007

dani2007 Nov 9, 2017

To creat a GCP file still has to been done manually, right?
If anyone has a good work flow, I'd apreciate any hints. If not, I'll ceat a txt file and use paint to get the pixel row and collum ;-). It's some work for 10 GCP but it will work.

Thanks for your wirk!

dani2007 commented Nov 9, 2017

To creat a GCP file still has to been done manually, right?
If anyone has a good work flow, I'd apreciate any hints. If not, I'll ceat a txt file and use paint to get the pixel row and collum ;-). It's some work for 10 GCP but it will work.

Thanks for your wirk!

@gkconsulting

This comment has been minimized.

Show comment
Hide comment
@gkconsulting

gkconsulting Nov 9, 2017

Contributor

Hi,
I have not done much work on this lately, however I have used this fork and works really well to generate my GCP file. Its a great and easy automated method.
https://github.com/wolkstein/OpenDroneMap-GCP_LIST.TXT-generator

I hope this helps

Contributor

gkconsulting commented Nov 9, 2017

Hi,
I have not done much work on this lately, however I have used this fork and works really well to generate my GCP file. Its a great and easy automated method.
https://github.com/wolkstein/OpenDroneMap-GCP_LIST.TXT-generator

I hope this helps

@dani2007

This comment has been minimized.

Show comment
Hide comment
@dani2007

dani2007 Nov 9, 2017

ah, thanks. I'll try this.

dani2007 commented Nov 9, 2017

ah, thanks. I'll try this.

@dakotabenjamin

This comment has been minimized.

Show comment
Hide comment
@dakotabenjamin
Member

dakotabenjamin commented Nov 9, 2017

@gkconsulting that is awesome. cc. @smathermather

@kikislater

This comment has been minimized.

Show comment
Hide comment
@kikislater

kikislater Nov 9, 2017

Contributor

Whaoooh !
Nice feature

Contributor

kikislater commented Nov 9, 2017

Whaoooh !
Nice feature

@dani2007

This comment has been minimized.

Show comment
Hide comment
@dani2007

dani2007 Nov 10, 2017

okey, I have no Idea about python or linux ;-P. Well I was proud already, that I got webODM to run ;-)

Well now I did al the steps with the the tempate images and so on. but how do I start the skript on windows? ;-). sorry for the stubid querstion

I tried it on the windwos start, Run, with:

C:\Python27\python.exe D:\DrohnenaufnahmenSammelarchiv\Bachs\105MEDIA\gcp_txt_gen.py But nothing happend ;-)

dani2007 commented Nov 10, 2017

okey, I have no Idea about python or linux ;-P. Well I was proud already, that I got webODM to run ;-)

Well now I did al the steps with the the tempate images and so on. but how do I start the skript on windows? ;-). sorry for the stubid querstion

I tried it on the windwos start, Run, with:

C:\Python27\python.exe D:\DrohnenaufnahmenSammelarchiv\Bachs\105MEDIA\gcp_txt_gen.py But nothing happend ;-)

@a5pire

This comment has been minimized.

Show comment
Hide comment
@a5pire

a5pire Nov 10, 2017

Start docker then:
cd webodm

then:
webodm.sh start

You should then be able to open a browser and type the webodm ip address and add the port 8000 to the end. If you're unsure of the address,

docker-machine ip

a5pire commented Nov 10, 2017

Start docker then:
cd webodm

then:
webodm.sh start

You should then be able to open a browser and type the webodm ip address and add the port 8000 to the end. If you're unsure of the address,

docker-machine ip

@dani2007

This comment has been minimized.

Show comment
Hide comment
@dani2007

dani2007 Nov 10, 2017

Sorry, no that was not my question. that I did get ;-)

I am trying to run the "https://github.com/wolkstein/OpenDroneMap-GCP_LIST.TXT-generator"

dani2007 commented Nov 10, 2017

Sorry, no that was not my question. that I did get ;-)

I am trying to run the "https://github.com/wolkstein/OpenDroneMap-GCP_LIST.TXT-generator"

@dani2007

This comment has been minimized.

Show comment
Hide comment
@dani2007

dani2007 Nov 11, 2017

okey, I spent a full day now to try to get the script running on a windows 10 maschine.

at first I tried it with python 3, witch did not seam to work. than I figured maybe I need python 2, then I tried to install numpy, in many different ways, wich somehow did not work. than I installed the Miniconda package, So i could run nimpy. Then I had to install CV2 somehow. and now gives me this:

(C:\Users\seich\AppData\Local\conda\conda\envs\my_root) C:\Users\seich>python C:\Bachserei\OpenDroneMapGCP\gcp_txt_gen.py
Found 0 Images
---sorted tmpImagePathList
Found 0 Images-Templates
Traceback (most recent call last):
File "C:\Bachserei\OpenDroneMapGCP\gcp_txt_gen.py", line 121, in
sift = cv2.SIFT()
AttributeError: 'module' object has no attribute 'SIFT'

(C:\Users\seich\AppData\Local\conda\conda\envs\my_root) C:\Users\seich>

dani2007 commented Nov 11, 2017

okey, I spent a full day now to try to get the script running on a windows 10 maschine.

at first I tried it with python 3, witch did not seam to work. than I figured maybe I need python 2, then I tried to install numpy, in many different ways, wich somehow did not work. than I installed the Miniconda package, So i could run nimpy. Then I had to install CV2 somehow. and now gives me this:

(C:\Users\seich\AppData\Local\conda\conda\envs\my_root) C:\Users\seich>python C:\Bachserei\OpenDroneMapGCP\gcp_txt_gen.py
Found 0 Images
---sorted tmpImagePathList
Found 0 Images-Templates
Traceback (most recent call last):
File "C:\Bachserei\OpenDroneMapGCP\gcp_txt_gen.py", line 121, in
sift = cv2.SIFT()
AttributeError: 'module' object has no attribute 'SIFT'

(C:\Users\seich\AppData\Local\conda\conda\envs\my_root) C:\Users\seich>

@dani2007

This comment has been minimized.

Show comment
Hide comment
@dani2007

dani2007 Nov 11, 2017

Okey, I tinkered around a litle more. i found out, that SIFT is no longer in openCV. :-(

https://www.pyimagesearch.com/2015/07/16/where-did-sift-and-surf-go-in-opencv-3/

so the skript does not work with up to date cv2 anymore. Maybe someone with a little more knowidge then me can fix this. ;-)

dani2007 commented Nov 11, 2017

Okey, I tinkered around a litle more. i found out, that SIFT is no longer in openCV. :-(

https://www.pyimagesearch.com/2015/07/16/where-did-sift-and-surf-go-in-opencv-3/

so the skript does not work with up to date cv2 anymore. Maybe someone with a little more knowidge then me can fix this. ;-)

@pierotofy

This comment has been minimized.

Show comment
Hide comment
@pierotofy

pierotofy Apr 19, 2018

Member

We now have the posm-gcpi plugin, so this can be probably closed.

Member

pierotofy commented Apr 19, 2018

We now have the posm-gcpi plugin, so this can be probably closed.

@pierotofy pierotofy closed this Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment