Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Crash when opening, saving and closing a level without any change #217

Closed
Bertram25 opened this issue Oct 3, 2014 · 8 comments
Closed
Assignees
Milestone

Comments

@Bertram25
Copy link
Contributor

@Bertram25 Bertram25 commented Oct 3, 2014

Might be linked to line endings according to @hwoarangmy

See here for the level tested with the windows build:
http://forum.freegamedev.net/viewtopic.php?p=59984#p59984

@Bertram25 Bertram25 added this to the Map Editor milestone Oct 3, 2014
@hwoarangmy
Copy link
Contributor

@hwoarangmy hwoarangmy commented Oct 6, 2014

I've looked at the file and it has been modified by the editor. I've seen 2 things :

  • Lot of spaces have been added at each line
  • subgoals handling "+ 1" have been changed to "1" resulting in every goal being considered main goals.

The problem @Danimal696 raised is caused by the spaces. Because of them, we do not see the end of the map information and we stay in an infinite loop. To fix that, I will add a trim to the parameters read from the map and check for the EOF in the loop.

@Danimal696
Copy link
Contributor

@Danimal696 Danimal696 commented Oct 6, 2014

For more information, i used microsoft excel 2010 to modify it; i have been using it previously on the all the other releases, this is the first one to present errors with it.

@Bertram25
Copy link
Contributor Author

@Bertram25 Bertram25 commented Oct 6, 2014

My proposal: @Danimal696 Never ever use an office tool to edit OD files again. I'd propose Scite and such to do so. Sorry.

@Danimal696
Copy link
Contributor

@Danimal696 Danimal696 commented Oct 6, 2014

is there any other option closer to what excel shows? plain text editor make it very hard to see columns

@Bertram25
Copy link
Contributor Author

@Bertram25 Bertram25 commented Oct 6, 2014

After the change on creatures, there won't be columns anymore in creature definitions.
Other than that, you can also set a monospaced font for your text, which should help a lot already. (That's what I do. ;])

@Bertram25
Copy link
Contributor Author

@Bertram25 Bertram25 commented Oct 7, 2014

Since the level was changed using an external unsupported tool, I'd propose to close this one as won't fix.

@hwoarangmy
Copy link
Contributor

@hwoarangmy hwoarangmy commented Oct 7, 2014

Even if it was modified with an unsupported tool, I think it is not acceptable to have endless loops. We might also have corrupted files or whatever. I will add in my next PR a fix to stop map loading when after EOF (at least for the case @Danimal696 raised. Concerning the subgoals handling problem, I agree, we don't have to fix it.
So I propose to close this issue when the EOF will be fixed.

@Bertram25
Copy link
Contributor Author

@Bertram25 Bertram25 commented Oct 7, 2014

So I propose to close this issue when the EOF will be fixed.

Fair enough. :)

@hwoarangmy hwoarangmy self-assigned this Oct 8, 2014
@hwoarangmy hwoarangmy closed this in 1713fb5 Oct 9, 2014
@Bertram25 Bertram25 modified the milestones: 0.4.9, Map Editor Dec 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants