Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sundtek-mediatv: fixed (some) errors #3601

Merged
merged 1 commit into from Nov 9, 2014
Merged

Conversation

@vpeter4
Copy link
Contributor

vpeter4 commented Nov 8, 2014

And decision should be made: keeping this addon alive as part of openelec or not. In second case I will maintain it and build it myself totally unofficially.

@@ -29,9 +29,11 @@
<setting id="ENABLE_TUNER_TYPES" type="bool" label="9005" default="true" />
<setting label="9010" option="close" type="action" action="RunScript($ID, refresh_tuners)" />
</category>
<!--
<category label="3000">
<setting type="sep" />
<setting id="CHECK_BOOT" type="bool" label="3020" default="false" />

This comment has been minimized.

Copy link
@stefansaraev

stefansaraev Nov 9, 2014

Contributor

CHECK_BOOT should be removed after you re-enable this setting block (CHECK_BOOT would still be set for old users and the update logic in sundtek*.start would still try to autoupdate?). this is a call for trouble. you have ZERO guarantee that network is ready at the time this starts..

EDIT: I think we agreed already to not have boot-time autoupdater. but an option for manual update only.

This comment has been minimized.

Copy link
@vpeter4

vpeter4 Nov 9, 2014

Author Contributor

Yes, will fix this. Thank you.
And there is NO autoupdate. At boot time it only checkes for new version and inform user.

This comment has been minimized.

Copy link
@stefansaraev

stefansaraev Nov 9, 2014

Contributor

oh, that's fine then. my apologies, I didnt check line by line..

This comment has been minimized.

Copy link
@vpeter4

vpeter4 Nov 9, 2014

Author Contributor

You see: I did listen once back in time :-) And read comments.

@stefansaraev

This comment has been minimized.

Copy link
Contributor

stefansaraev commented Nov 9, 2014

@sraue please merge and rebuild asap. atm sundtek addon is not even listed in repos because of a typo..

up to you if autoupdate on boot should be removed immediately or later.

sraue added a commit that referenced this pull request Nov 9, 2014
sundtek-mediatv: fixed (some) errors
@sraue sraue merged commit 4f1610c into OpenELEC:master Nov 9, 2014
@stefansaraev

This comment has been minimized.

Copy link
Contributor

stefansaraev commented Nov 9, 2014

And decision should be made: keeping this addon alive as part of openelec or not. In second case I will maintain it and build it myself totally unofficially

@vpeter4 I, personaly, prefer to keep it alive in official repos, as we "officialy" support preloading in vdr / tvheadend startscripts. as long it works, removing it means "we do not want to support your hardware" and then vdr/tvh should be cleaned up, too. that sends bad message to sundtek and their users. that's just my opinion of course. who am I..

EDIT: again, to be clear. removal is "no-no" if it doesnt break things that always worked.. and if it doesnt block us from adding new features.

@vpeter4 vpeter4 deleted the vpeter4:sundtek branch Nov 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.