New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kodi: enhance english kb layout a bit. #4217

Merged
merged 1 commit into from Jul 1, 2015

Conversation

Projects
None yet
3 participants
@stefansaraev
Contributor

stefansaraev commented Jun 27, 2015

as title says. adding . : / @ keys to english virtual keyboard.

I wont send this upstream because meh bikesheding.

let me know if this is acceptable here or not.

@sraue

This comment has been minimized.

Contributor

sraue commented Jul 1, 2015

yes it is, please merge if you like

stefansaraev added a commit that referenced this pull request Jul 1, 2015

Merge pull request #4217 from stefansaraev/kb
kodi: enhance english kb layout a bit.

@stefansaraev stefansaraev merged commit 6c016f6 into OpenELEC:master Jul 1, 2015

@stefansaraev stefansaraev deleted the stefansaraev:kb branch Jul 1, 2015

@NedScott

This comment has been minimized.

NedScott commented Sep 28, 2015

If you PR this to upstream Kodi I promise not to bikeshed, and I'll beat up anyone who does :D

@stefansaraev

This comment has been minimized.

Contributor

stefansaraev commented Sep 28, 2015

I did. once. wont happen again. if you want, pick it :)

stevegal added a commit to stevegal/xbmc that referenced this pull request Jan 9, 2016

Improve virtual keyboard layout for English
Previously discussed:

xbmc#6843

There were some objections, some request for comments from the community, but in the end nothing better got suggested other than the more simplified layout that was then added to OpenELEC:

OpenELEC/OpenELEC.tv#4217

So far the OpenELEC change has been very positive and hasn't caused any issues, as previously feared. I'm hoping that is enough to push this through.

Other language or alternative layouts are welcome to suggest their own changes. I think it is a fair argument that their changes will be different for different areas/people/localization/whatever. In the long run, a contextually sensitive row would be better (context specific to URL entry, e-mail entry, title entry, etc), but this is the best we can do with the current code, and makes using the on-screen-keyboard much nicer (oh god, the URLs!).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment