New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add docker support to all projects #4273
Conversation
For run docker I need libdevmapper: PKG_NAME="LVM2" PKG_IS_ADDON="no" pre_configure_target() { make_target() { makeinstall_target() { But when I build I receive this error: /tmp/cc7ttLBw.ltrans1.ltrans.o::function _display_info.lto_priv.52: error: undefined reference to 'dm_task_get_info' Any suggestion? |
I got it to build using this, http://sprunge.us/KINL However I am not really into having LVM in OpenELEC. So you should try to package it as an add-on. |
Thanks @lrusak, it works. I'm testing with RPi2. |
@lrusak for intel platform there is no need of this dependency, I´m trying to build the docker version for RPi and it need some patches (i will remove libdevmapper dependency). |
I have already tested the changes in all the devices I have (Generic, Nvidia_Legacy and RPi2). Now, about the rest of platforms I don't have, do you have any suggestions on how to test them? How do you usually manage to try them all? |
simply enable/change all kernel config options like on the other projects so the changes are similiar |
@sony2 are you sure all the config options are required? Can you check if the options in raspberrypi/linux#1027 give the features you need? |
do we really need all this kernel config changes? if MEMCG is not needed and bad on RPi, do we need this for our x86 projects? |
Sorry about the late reply, I was on holiday. It´s better to have MEMCG active, but the performance in RPi is bad by the moment. |
@sony2 I can help with testing on imx6 |
@sony2 After looking into this I have some findings. Initially support should only be brought to the Generic, Generic_legacy, RPi, and RPi2 platforms. The imx6 and WeTek_Play use too old of kernels to use overlayfs (which is the easiest to setup because OpenELEC uses ext4 filesystem). Take a look at my branch where I have docker compiling as an add-on for OE. If you have any questions please ask. I have tested on Generic and RPi2 with success. Using the docker provided tool here I adjusted the RPi2 kernel config. I have MEMCG but no MEMCG_SWAP or MEMCG_KMEM. Maybe @popcornmix can take a look at this on my branch as well. You can drop the changes to systemd-addon-wrapper, they are not needed. So for now please focus on Generic_Legacy, RPi and RPi2. Please rebase, squash and cleanup your commits. |
@vaskas yes I can, I have already built lxc and can make it an addon, might be able to package systemd-nspawn as well. Please ping me on IRC or email me so we can take the discussion off github. |
Sorry, the last few weeks have been very busy. I have studied imx6 and WeTek_Play and effectively the kernel is too old. |
@lrusak Is now the code ok to merge? |
Looks fine to me. @sraue it's up to you. |
I'd love to try this on the nvidia_legacy project. Is there any nightly test build I can try before this is merged in? |
All of the Nvidia_Legacy kernel options added here appear to be in master and OE 6 already, most likely as defaults with the 4.3 kernel, so try OE6. This PR needs rebasing, or closing (the RPi/RPi2 kernel options might need rebasing). |
I need to check the master and then I will rebase the options needed. |
Why is this closed? |
#4256
Add support for all projects: