New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS namespacing rules to spec for Container Developers #37

Merged
merged 3 commits into from Apr 8, 2013

Conversation

Projects
None yet
2 participants
@brianbaker
Member

brianbaker commented Apr 6, 2013

Similar to the Namespacing section of the App Development spec, add details around applying CSS specificity for Container Development.

@ghost ghost assigned markhealey Feb 28, 2013

@brianbaker

This comment has been minimized.

Show comment
Hide comment
@brianbaker

brianbaker Feb 28, 2013

Member

Created issue37 branch with possible updates for the example container. I pulled in the .less files from bootstrap and ran them through lessc in order to namespace them inside of .f2-example-container. Also added a README to instruct users on how to build the css for themselves.

Member

brianbaker commented Feb 28, 2013

Created issue37 branch with possible updates for the example container. I pulled in the .less files from bootstrap and ran them through lessc in order to namespace them inside of .f2-example-container. Also added a README to instruct users on how to build the css for themselves.

@brianbaker

This comment has been minimized.

Show comment
Hide comment
@brianbaker

brianbaker Feb 28, 2013

Member

I guess one thing to add on this is that a site that has chosen Bootstrap as its framework really doesn't need to namespace the css. Namespacing of the css is really just an FYI for sites that have an existing CSS framework and they don't want it to conflict with what Bootstrap has.

Container developers should still plan on customizing Bootstrap - that is if they want it to match their site's fonts, colors, etc.

Member

brianbaker commented Feb 28, 2013

I guess one thing to add on this is that a site that has chosen Bootstrap as its framework really doesn't need to namespace the css. Namespacing of the css is really just an FYI for sites that have an existing CSS framework and they don't want it to conflict with what Bootstrap has.

Container developers should still plan on customizing Bootstrap - that is if they want it to match their site's fonts, colors, etc.

@markhealey

This comment has been minimized.

Show comment
Hide comment
@markhealey

markhealey Mar 7, 2013

Member

This didn't make it in 1.1 and I've updated the milestone to show 1.1.2 which is coming soon.

Member

markhealey commented Mar 7, 2013

This didn't make it in 1.1 and I've updated the milestone to show 1.1.2 which is coming soon.

markhealey pushed a commit that referenced this pull request Apr 4, 2013

@brianbaker

This comment has been minimized.

Show comment
Hide comment
@brianbaker

brianbaker Apr 6, 2013

Member

Tried out using hub to associate this branch/pull request with this issue, but didn't see that @markhealey had already merged it. oh well.

Member

brianbaker commented Apr 6, 2013

Tried out using hub to associate this branch/pull request with this issue, but didn't see that @markhealey had already merged it. oh well.

@brianbaker brianbaker referenced this pull request Apr 6, 2013

Merged

1.1.2 wip #65

@brianbaker brianbaker merged commit 94db6c1 into master Apr 8, 2013

@brianbaker brianbaker deleted the issue37 branch Apr 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment