Release 1.2 #69

Merged
merged 221 commits into from Jun 7, 2013

Conversation

Projects
None yet
4 participants
@brianbaker
Member

brianbaker commented Apr 9, 2013

Tracking changes for the 1.2 release

  • AppHandlers - #4, (#38, #85), #66
  • Preloaded Apps - #68, #88, #93
  • Source Maps - (#28, #76)
  • JS Hint - (#74, #78)
  • Dynamic rows in example container - (#20, #82)
  • Package.json - (no Issue #)
  • Upgrade examples to TwBs 2.3.1 - (no Issue #)
  • Various example app updates - (no Issue #)
  • Bug Fixes - #71, (#77, #79), (#80, #81)
  • JSON/POST/XHR overrides - (#59, #90)
  • Add upgrading notes to F2.js SDK

Regarding #38:

  • @markhealey, Remove all appRender references in docs, examples, fiddles, downloads
  • @markhealey, Update spec documentation to use F2.AppHandlers
  • @Ali-Khatami, Update sdk documentation to explain what is passed to the listeners. For example, when binding to F2.Constants.AppHandlers.APP_RENDER, it looks like an appConfig and maybe a string of html that represents the app
  • @Ali-Khatami, Fix errors reported by JS Hint when the shadow option is disabled
  • @Ali-Khatami, @markhealey, List the order in which the events are executed. This should either be done in the sdk or the spec and linked to each other
  • @Ali-Khatami, Update the container-amd example to use AppHandlers. I think its safe to only use AppHandlers for this example. We don't need two versions (like container.js and container-app-handlers.js for the non-amd example).
  • Remove all reload placeholder code to a separate branch or else delete it entirely.
  • Add in function arguments to the _defaultMethods so that developers can easily see the defaults and their arguments.
  • Should the handlers pass their return result on to the next handler? For example, if one AppRender method modifies some html, how do subsequent handlers modify that html further?
  • The _createAppInstance function does not behave the same as it does in 1.1. In 1.1 it created the instance like new F2.Apps[appId](appConfig, appContent, appRoot);. In 1.2, it is no longer passing the appContent but instead the html for the app: new F2.Apps[appId](appConfig, appHtml, appRoot). This needs to be made backwards compatible with 1.1.
  • Looks like all of the docs templates somehow had their handlebars code removed and hard-coded in at least one of the commits

Regarding #68:

  • #88 - F2.registerPreLoadedApps should add classNames to root element
  • F2.registerPreloadedApps should be F2.registerApps per #97 and comment

Ali-Khatami added some commits Mar 21, 2013

Looks like that was it! jQuery wasn't being loaded because of the // …
…trick. Forced it to https:// and life is good!
More stability. Plugged in initial version of App Destroy logic. Stil…
…l need to write Unit tests, document the code, and add a new example container.
Merge branch '1.2-wip' of https://github.com/OpenF2/F2 into Container…
…-Event_Rendering-Additions. Wanted to make sure this branch is up to date with at least the latest in 1.2-wip
Added logic to default appRender so that you can basically call init …
…only and your container will load apps without you having to do anything. Also ran docs and compiled code via node.
Created a separate version of container.js which is container-app-han…
…dlers.js to show the new way of handling apps.
Merge remote-tracking branch 'remotes/origin/1.2-wip-travis-ci' into …
…HEAD

Conflicts:
	build/F2.json
	docs/app-development.html
	docs/container-development.html
	docs/extending-f2.html
	docs/f2js-sdk.html
	docs/index.html
	docs/sdk/classes/F2.App.html
	docs/sdk/classes/F2.AppConfig.html
	docs/sdk/classes/F2.AppManifest.AppContent.html
	docs/sdk/classes/F2.AppManifest.html
	docs/sdk/classes/F2.Constants.Css.html
	docs/sdk/classes/F2.Constants.Events.html
	docs/sdk/classes/F2.Constants.Sockets.html
	docs/sdk/classes/F2.Constants.Views.html
	docs/sdk/classes/F2.Constants.html
	docs/sdk/classes/F2.ContainerConfig.UI.Mask.html
	docs/sdk/classes/F2.ContainerConfig.UI.html
	docs/sdk/classes/F2.ContainerConfig.html
	docs/sdk/classes/F2.Events.html
	docs/sdk/classes/F2.Rpc.html
	docs/sdk/classes/F2.UI.Modals.html
	docs/sdk/classes/F2.UI.Views.html
	docs/sdk/classes/F2.UI.html
	docs/sdk/classes/F2.html
	docs/sdk/files/sdk_src_classes.js.html
	docs/sdk/files/sdk_src_constants.js.html
	docs/sdk/files/sdk_src_container.js.html
	docs/sdk/files/sdk_src_events.js.html
	docs/sdk/files/sdk_src_rpc.js.html
	docs/sdk/files/sdk_src_ui.js.html
	docs/sdk/index.html
	docs/sdk/modules/f2.html
	sdk/f2.no-third-party.js
Merge remote-tracking branch 'remotes/origin/Container-Event_Renderin…
…g-Additions' into 1.3-wip-app-handlers

Conflicts:
	docs/app-development.html
	docs/container-development.html
	docs/extending-f2.html
	docs/js/f2.js
	docs/js/f2.min.js
	docs/sdk/classes/F2.ContainerConfig.UI.Mask.html
	docs/sdk/classes/F2.ContainerConfig.UI.html
	docs/sdk/classes/F2.ContainerConfig.html
	docs/sdk/classes/F2.html
	docs/sdk/index.html
	sdk/f2.min.js
	tests/index.html
	tests/spec/container-spec.js

markhealey and others added some commits May 31, 2013

Updates to fix complete "Update sdk documentation to explain what is …
…passed to the listeners. For example, when binding to F2.Constants.AppHandlers.APP_RENDER, it looks like an appConfig and maybe a string of html that represents the app" and "List the order in which the events are executed. This should either be done in the sdk or the spec and linked to each other" from 1.2-wip pull request #69
Resolved issues with F2.Constants.AppHandlers not being a closure tha…
…t executes immediately which in turn resolved tests not running.

markhealey and others added some commits Jun 3, 2013

Mark Healey added some commits Jun 4, 2013

@ghost ghost assigned markhealey Jun 4, 2013

markhealey pushed a commit that referenced this pull request Jun 7, 2013

@markhealey markhealey merged commit 836efec into master Jun 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment