fvMeshTopoChangers::refiner: Fix hang in parallel

This has required switching the order of dependence of the fvMesh
geometry (i.e., Sf, Cf, and C), and the interpolation weights. The
weights are now considered dependent on the geometry fields, and the
geometry fields must therefore construct without reference to the
weights.

Author: Will Bainbridge

src/finiteVolume/interpolation/surfaceInterpolation/surfaceInterpolation/surfaceInterpolation.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -158,15 +158,11 @@ void Foam::surfaceInterpolation::makeWeights() const
     surfaceScalarField& weights = *weights_;
 
     // Set local references to mesh data
-    // (note that we should not use fvMesh sliced fields at this point yet
-    //  since this causes a loop when generating weighting factors in
-    //  coupledFvPatchField evaluation phase)
     const labelUList& owner = mesh_.owner();
     const labelUList& neighbour = mesh_.neighbour();
-
-    const vectorField& Cf = mesh_.faceCentres();
-    const vectorField& C = mesh_.cellCentres();
-    const vectorField& Sf = mesh_.faceAreas();
+    const surfaceVectorField& Sf = mesh_.Sf();
+    const surfaceVectorField& Cf = mesh_.Cf();
+    const volVectorField& C = mesh_.C();
 
     // ... and reference to the internal field of the weighting factors
     scalarField& w = weights.primitiveFieldRef();

src/fvMeshTopoChangers/refiner/fvMeshTopoChangersRefiner.C

@@ -575,10 +575,7 @@ void Foam::fvMeshTopoChangers::refiner::refineUfs
         {
             const surfaceVectorField UfU
             (
-                fvc::interpolate
-                (
-                    mesh().lookupObject<volVectorField>(Uname)
-                )
+                fvc::interpolate(mesh().lookupObject<volVectorField>(Uname))
             );
 
             // Recalculate new internal faces.