Skip to content
Permalink
Tree: 5c188ddce7
Commits on Jun 21, 2019
  1. Completed standardisation of the class declaration section comments t…

    Henry Weller
    Henry Weller committed Jun 21, 2019
    …o correspond to the foamNewSource template
Commits on Jun 20, 2019
  1. Solvers: standardised the class declaration section comments to corre…

    Henry Weller
    Henry Weller committed Jun 20, 2019
    …spond to the foamNewSource template
  2. Standardised and rationalised the way in which units are written in f…

    Henry Weller
    Henry Weller committed Jun 20, 2019
    …unction documentation
Commits on Jun 19, 2019
  1. Utilities: standardised the class declaration section comments to cor…

    Henry Weller
    Henry Weller committed Jun 19, 2019
    …respond to the foamNewSource template
  2. Standardised the class declaration section comments to correspond to …

    Henry Weller
    Henry Weller committed Jun 19, 2019
    …the foamNewSource template
  3. Standardised the class declaration section comments to correspond to …

    Henry Weller
    Henry Weller committed Jun 19, 2019
    …the foamNewSource template
  4. Standardised the class declaration section comments to correspond to …

    Henry Weller
    Henry Weller committed Jun 19, 2019
    …the foamNewSource template
Commits on Jun 18, 2019
  1. fvOptions::isotropicDamping: New wave damping fvOption

    Henry Weller
    Henry Weller committed Jun 18, 2019
    This implicit isotropic damping function relaxes the velocity field towards a
    specified uniform value which can be set to (0 0 0) if no flow is required.
    This is particularly appropriate to damp the waves in a closed wave tank with no
    mean flow.
    
    Testing on the interFoam wave has shown that for this simple case with uniform
    mean flow the new isotropicDamping fvOption provides more rapid and complete
    damping than the original verticalDamping.
Commits on Jun 13, 2019
  1. Standardised the class declaration section comments to correspond to …

    Henry Weller
    Henry Weller committed Jun 13, 2019
    …the foamNewSource template
  2. cut: Templated point type

    Will Bainbridge
    Will Bainbridge committed Jun 13, 2019
    This allows for different information to be passed around the cut
    routines; in particular, classes representing the topology of the cuts.
Commits on Jun 11, 2019
  1. mixtureKEpsilon: Added documentation for the bubble generated turbule…

    Henry Weller
    Henry Weller committed Jun 11, 2019
    …nce coefficient
  2. nutURoughWallFunction: Updated handling of the low y+ region, consist…

    Henry Weller
    Henry Weller committed Jun 11, 2019
    …ent with nutkRoughWallFunction
    
    Results for nutkRoughWallFunction and nutURoughWallFunction are now reasonably
    consistent and both are now more robust and handle small near-wall cells more
    reliably.  However if the wall roughness height is large, ~domain width, the
    nutURoughWallFunction produces a lot less realistic results than the
    nutkRoughWallFunction which appears to behave surprisingly well.
Commits on Jun 10, 2019
  1. etc/templates/singleFluidCHT/README: Corrected typo

    Henry Weller
    Henry Weller committed Jun 10, 2019
    Resolves bug report https://bugs.openfoam.org/view.php?id=3290
    
    Tested-by: Henry Weller <http://openfoam.org>
Commits on Jun 8, 2019
  1. tutorials/incompressible/boundaryFoam/boundaryWallFunctionsProfile/Al…

    Henry Weller
    Henry Weller committed Jun 8, 2019
    …lrun: Updated for latest gnuplot
  2. snappyHexMesh::meshRefinement: clear the mesh before mapping to avoid…

    Henry Weller
    Henry Weller committed Jun 8, 2019
    … issues with mapping the mesh flux field
  3. nutURoughWallFunction: Updated for input consistency with nutkRoughWa…

    Henry Weller
    Henry Weller committed Jun 8, 2019
    …llFunction
    
    Now both the nutkRoughWallFunction and nutURoughWallFunction us the same field
    based Ks and Cs input to support non-uniform surface roughness.
    
    Note that nutURoughWallFunction is not exactly consistent with the
    nutUWallFunction in the limit of roughness height = 0 and also not consistent
    with nutkRoughWallFunction, particularly if the near-wall cell is in the laminar
    sub-layer for which nutURoughWallFunction is currently incorrect.
    
    Significant further work on the nutURoughWallFunction is needed to make it
    consistent with both the nutUWallFunction and nutkRoughWallFunction BCs.
  4. nutkRoughWallFunction: Further rationalisation

    Henry Weller
    Henry Weller committed Jun 8, 2019
Commits on Jun 7, 2019
  1. nutkRoughWallFunction: Re-derived and implemented to improve stabilit…

    Henry Weller
    Henry Weller committed Jun 7, 2019
    …y and range of applicability
    
    This wall function is now stable even if the near-wall cell centre distance is
    less than the roughness height although it is unlikely to be very accurate if
    used in this way.
    
    The sudden change limit stabilisation has been re-implemented to avoid the
    near-wall viscosity being lower limited to half the laminar viscosity which has
    no physical meaning.
Commits on Jun 6, 2019
  1. rigidBodyMeshMotion, rigidBodyMeshMotionSolver, rigidBodyMeshMotionSo…

    Henry Weller
    Henry Weller committed Jun 6, 2019
    …lver: ensure state dictionary is written ASCII
    
    Resolves bug-report https://bugs.openfoam.org/view.php?id=3288
Commits on Jun 5, 2019
  1. Added copy constructors to classes with copy assignment operator defined

    Henry Weller
    Henry Weller committed Jun 5, 2019
    and copy assignment operator for classes with a copy constructor
    
    This is often described as the rule of 3 (or rule of 5 in C++11 if move
    constructors and assignment operators are also defined) and makes good sense in
    ensuring consistency.  For classes in which the default bitwise copy constructor
    or assignment operator are appropriate these are now specified explicitly using
    the "= default" keyword if the other is explicitly defined fulfilling the rule
    of 3 without the need to define the body of the function.
Commits on Jun 4, 2019
  1. rotorDiskSource: Use the scalar sign function

    Henry Weller
    Henry Weller committed Jun 4, 2019
  2. rotorDiskSource: Enable opposite spin in rotorDisk, for fixed thrust …

    Henry Weller
    Henry Weller committed Jun 4, 2019
    …direction
    
    Patch contributed by Robert Lee
    Resolves patch request https://bugs.openfoam.org/view.php?id=3285
Commits on Jun 3, 2019
  1. Lagrangian: Removed more instances of random-number-based perpendicul…

    Will Bainbridge
    Will Bainbridge committed May 28, 2019
    …ar vector calculations
    
    Perpendicular vectors should be generated using the global
    "perpendicular" function, which guarantees a non-zero result without a
    random number generator and without looping.
Commits on Jun 2, 2019
  1. nutWallFunction: Added a nutw static function to return the nutWallFu…

    Henry Weller
    Henry Weller committed Jun 2, 2019
    …nction patchField for a given patch
Commits on May 31, 2019
  1. Rationalised wall function implementation to avoid complex and incons…

    Henry Weller
    Henry Weller committed May 31, 2019
    …istent coefficients
    
    All wall functions now operate collaboratively, obtaining the Cmu, kappa and E
    coefficients and yPlusLam from the nutWallFunction base class.  Now these
    optional inputs need only be specified in the nut boundary condition with the k,
    epsilon, omega, v2 and f wall functions obtaining these values from there.  This
    is much simpler to specify and avoids inconsistencies in the operation of the
    wall functions for the different turbulence fields.
    
    The code has also been rationalised and simplified avoiding unnecessary code
    and duplication.
Commits on May 29, 2019
  1. src/OpenFOAM: Moved the deleted bitwise copy and assignment declarati…

    Henry Weller
    Henry Weller committed May 29, 2019
    …ons into public section of the class
Commits on May 28, 2019
  1. HookFunctions: Ensure the checkHeaderIfndefNames is applied only if t…

    Henry Weller
    Henry Weller committed May 28, 2019
    …he "_H" is at the end of the line
  2. Added "= delete" to disabled bitwise copy constructors and assignment…

    Henry Weller
    Henry Weller committed May 28, 2019
    … operators
    
    Currently these deleted function declarations are still in the private section
    of the class declarations but will be moved by hand to the public section over
    time as this is too complex to automate reliably.
Commits on May 27, 2019
  1. Standardised copy constructor documentation comment

    Henry Weller
    Henry Weller committed May 27, 2019
Commits on May 26, 2019
  1. rotorDiskSource: Added output of rotor power

    Henry Weller
    Henry Weller committed May 26, 2019
    Patch contributed by Robert Lee
    Resolves patch request https://bugs.openfoam.org/view.php?id=3262
  2. cuttingPlane: Corrected handling of intersection between a plane and …

    Henry Weller
    Henry Weller committed May 26, 2019
    …a cellZone in parallel
    
    Patch contributed by Federico Piscaglia
    Resolves bug-report https://bugs.openfoam.org/view.php?id=3283
  3. Comment spelling corrections from codespell

    Henry Weller
    Henry Weller committed May 26, 2019
Older
You can’t perform that action at this time.