Skip to content

Conversation

@knoxfighter
Copy link
Member

Removed the HiddenSidebar, it throwed multiple errors and i dont think it was used at all.

For me it's now working fine.

The Login-Page is still very weird looking, but working.

@mroote
Copy link
Member

mroote commented Mar 1, 2019

I checked out this code and made a build but I still seem to be getting the <Route> elements are for router configuration only and should not be rendered. I'm looking at react-router now to see if I can spot where the error is from but I'm not too familiar with the newer versions of react-router.

@mroote
Copy link
Member

mroote commented Mar 1, 2019

I think I found the issue, we had Route imported from react-router instead of react-dom-router. I can load the login page when I make that change.

@mroote
Copy link
Member

mroote commented Mar 1, 2019

Thanks for looking into this so quickly @knoxfighter!

@mroote mroote merged commit 2a69a8d into OpenFactorioServerManager:develop Mar 1, 2019
@knoxfighter knoxfighter deleted the fix-#123 branch May 30, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants