Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of GET with body in java11 Module #1819

Merged
merged 1 commit into from Nov 2, 2022
Merged

Allow usage of GET with body in java11 Module #1819

merged 1 commit into from Nov 2, 2022

Conversation

f-cramer
Copy link
Contributor

Although discouraged there are unfortunately some web services that require a body to be sent with GET requests. Java 11's integrated http client allows this under the hood, but feigns java11 module currently does not. This PR adds support for bodys with any request method.

Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also get a test updated to match this change?

@f-cramer
Copy link
Contributor Author

f-cramer commented Nov 1, 2022

I added two short tests that use the same API as the other tests an show that a Request Body transmitted via GET or DELETE is also present in the response

@velo
Copy link
Member

velo commented Nov 2, 2022

I added two short tests that use the same API as the other tests an show that a Request Body transmitted via GET or DELETE is also present in the response

Thanks for that, seems build is not passing, recommend running locally to check

@f-cramer
Copy link
Contributor Author

f-cramer commented Nov 2, 2022

Formatting... sorry for that

velo
velo approved these changes Nov 2, 2022
@velo velo merged commit 950935d into OpenFeign:master Nov 2, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants