Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor method signature of MethodHandler.Factory.create #1822

Merged

Conversation

wplong11
Copy link
Collaborator

@wplong11 wplong11 commented Nov 5, 2022

Refactor to unify value passing style like other values injected into the constructor.

@wplong11 wplong11 force-pushed the refactor-constructor-of-ParseHandlerByName branch from 038bf62 to abc936a Compare November 5, 2022 15:31
@wplong11 wplong11 changed the title Refactor constructor of ParseHandlerByName Refactor method signature of MethodHandler.Factory.create Nov 5, 2022
@wplong11 wplong11 force-pushed the refactor-constructor-of-ParseHandlerByName branch 3 times, most recently from 2b8f388 to 8c036a7 Compare November 5, 2022 15:43
velo
velo approved these changes Nov 6, 2022
@wplong11
Copy link
Collaborator Author

wplong11 commented Nov 7, 2022

@velo Please rerun the ci pipeline

@velo
Copy link
Member

velo commented Nov 7, 2022

@velo Please rerun the ci pipeline

can't....

image

did you block circle CI or have anything special on your fork?

@wplong11 wplong11 force-pushed the refactor-constructor-of-ParseHandlerByName branch from 8c036a7 to b57e5c9 Compare November 8, 2022 02:43
@wplong11
Copy link
Collaborator Author

wplong11 commented Nov 8, 2022

@velo CI Passed! I signed in to Circle CI again, approved the repo read permission, and synced the master branch of the fork repo with upstream.

@wplong11 wplong11 force-pushed the refactor-constructor-of-ParseHandlerByName branch from b57e5c9 to c063215 Compare November 9, 2022 06:01
velo
velo approved these changes Nov 9, 2022
@velo velo merged commit 8a68ace into OpenFeign:master Nov 9, 2022
6 checks passed
@wplong11 wplong11 deleted the refactor-constructor-of-ParseHandlerByName branch November 10, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants