Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using SOAPEncoder constructor taking builder #1841

Merged
merged 4 commits into from Nov 18, 2022

Conversation

Nicklas2751
Copy link
Contributor

Change the SOAPEncoder constructor which takes a builder from private to protected

Fixes #1839

Nicklas2751 and others added 2 commits Nov 15, 2022
…hanging the protocol when overwriting the class

Change the SOAPEncoder constructor which takes a builder from private to protected

Fixes OpenFeign#1839
@@ -93,7 +93,7 @@ public class SOAPEncoder implements Encoder {
private final JAXBContextFactory jaxbContextFactory;
private final String soapProtocol;

private SOAPEncoder(Builder builder) {
protected SOAPEncoder(Builder builder) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be make it public instead?

velo
velo approved these changes Nov 18, 2022
@velo velo merged commit 3a39bc6 into OpenFeign:master Nov 18, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify SOAP message and change SOAP protocol
2 participants