v2 GH sync is broken

[josephjclark]

I just pushed a release but I don't think that it affected this.

v2 sync worked fine back in feb - I can see the commit. But right now if I commit to GH, the deploy action fails. It doesn't seem to load the API key. Looking at the action code I'm not sure how that's supposed to work.

I'm going to deprecate this release just to validate whether this is a new break - then I'll decide what to do.

[josephjclark]

1.36.1 is deprecated

Running v2 deploy with 1.36.0 works great!

Ok, so I broke it. Dang.

[josephjclark]

This is incredibly weird. I can't see how this has changed 🤔

The environment hasn't changed, and in local testing the env var is respected.

If the env var is not set, an error should be thrown. But it wasn't.

Here is the commit in question: https://github.com/OpenFn/joe-ghsync-2/actions/runs/26295066402

[CLI] ♦ Detected openfn.yaml file - switching to v2 deploy (openfn project deploy). Set PREFER_LEGACY_SYNC to disable this.
[CLI] ⚠ WARNING: the project deploy command is in BETA and may not be stable. Use cautiously on production projects.
[CLI] ✔ Loaded checked-out project joe-ghsync-v2 (dc50a0d8-a4dd-434f-8ea3-70aaf0a2acaf)
[CLI] ⚠ Skipping compatibility check as no local version history detected
[CLI] ⚠ Pushing these changes may overwrite changes made to the app

[CLI] ♦ This will make the following changes to the remote project:

[CLI] ♦ Event-based workflow: changed
[CLI] ♦     Transform data:
[CLI] ♦       - expression: +1 lines

[CLI] ✘ Deploy failed with code  401
[CLI] ✘ Failed to deploy project:
[CLI] ✘ {
  "error": "Unauthorized"
}

If the api key was not set, this should have thrown an error before it tried to deploy (should have failed super early too). Which tells me that it's somehow loaded the wrong key

Local error (on 1.36.1) if the key was not set:

[CLI] ♦ Imported 7 env vars from .env file
[CLI] ♦ Detected openfn.yaml file - switching to v2 deploy (openfn project deploy). Set PREFER_LEGACY_SYNC to disable this.
[CLI] ⚠ WARNING: the project deploy command is in BETA and may not be stable. Use cautiously on production projects.

[CLI] ✘ Command failed!
[CLI] ✘ OPENFN_API_KEY is required. Set it in .env, pass --api-key, or set the environment variable.