Gate 9.0 does not fill Hits Tree

[ckaraf]

I have compiled Gate 9.0 using Geant 10.6.2 and root 6.22.00.
However, when I run my script Gate does not fill the Hits Tree although I use:

/gate/output/root/enable
/gate/output/root/setRootNtupleFlag 1
/gate/output/root/setRootHitFlag 1
/gate/output/root/setRootSinglesFlag 1

Gate 8.2 fills the Hits tree correctly.

[djboersma]

I think that the same problem is now reported on the user mailing list with more details:
http://lists.opengatecollaboration.org/pipermail/gate-users/2020-August/011878.html

I'm wondering if this has anything to do with the memory leak issues (e.g. #257) that were solved in Nov/Dec 2019, PR #266. @cpommranz , could you maybe comment on this? I might be completely off, of course, but I just wonder if the problem reported here could be an unintended side effect of that mem leak fix.

[cpommranz]

This seems to be correct @djboersma, good catch!

Without having deeply looked into this, all I can say right now is that the problem disappears as soon as PR #266 is reverted. But by reverting the PR, we get the memory leak back (also for the test simulation given in the linked mail). I will have a look into this again soon.

[cpommranz]

It turns out that G4SDManager::GetSDMpointer()->Activate(name, false); sets the sensitive detector itself to inactive. This inactive SD is later attached to the GateMultiSensitiveDetector.

The underlying problem is, as written in the commit message in PR #266, that Geant4 does not expose the G4SDStructure member function void RemoveSD(G4VSensitiveDetector*) and we therefore have no way to properly detach a SD from a volume. The only workaround (a very ugly one) I could find right now is to add a cloned but inactive version of the SD to the G4SDManager (which implicitly will remove the original and active SD) and use the original SD for the GateMultiSensitiveDetector. This is a rather dirty hack, so if anyone comes up with a better solution, I would very much appreciate it.

In parallel, I think we should try to get a RemoveDetector (or similar) member function into upstream Geant4's G4SDManager, similar to void AddNewDetector(G4VSensitiveDetector*aSD).

[dsarrut]

merge #354

[dsarrut]

Please @ckaraf, could you check if it works with this solution ?

[ckaraf]

ok, I'll have a look Thanks! C.

…

On Mon, 14 Sep 2020 at 17:57, David Sarrut ***@***.***> wrote: Please @ckaraf <https://github.com/ckaraf>, could you check if it works with this solution ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#350 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALCLCAHKGXPLSMSUX54UOUTSFYVMPANCNFSM4PD3EZNA> .

-- [image: photo] Dr Costas Karafasoulis at Hellenic Army Academy M +30-6973724688 <+30-6973724688> E ckaraf@gmail.com <ckaraf@gmail.com> W http://sites.google.com/site/ckaraf <http://sites.google.com/site/ckaraf> Viber +30-6973724688 Skype ckaraf <#SignatureSanitizer_>

[ckaraf]

Dear all, I confirm that the developer version of Gate on GitHub does fill the Hits Tree. Thank you,

…

On Mon, 14 Sep 2020 at 17:57, David Sarrut ***@***.***> wrote: Please @ckaraf <https://github.com/ckaraf>, could you check if it works with this solution ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#350 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALCLCAHKGXPLSMSUX54UOUTSFYVMPANCNFSM4PD3EZNA> .

-- [image: photo] Dr Costas Karafasoulis at Hellenic Army Academy M +30-6973724688 <+30-6973724688> E ckaraf@gmail.com <ckaraf@gmail.com> W http://sites.google.com/site/ckaraf <http://sites.google.com/site/ckaraf> Viber +30-6973724688 Skype ckaraf <#SignatureSanitizer_>

[jasqs]

Hi,

I confirm the same. I have tested this and it gives the same results as Gate 8.2.

thanks

[dsarrut]

cool! Big 👍 to @cpommranz !