Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple additions #199

merged 36 commits into from Nov 6, 2018


None yet
3 participants
Copy link

TomThePhysicist commented Oct 25, 2018

This pull request contains several additions:

  • Optimization of the VoxelizedMass class memory usage
  • Integration of the VoxelizedMass methods into the KermaActor
  • Addition of a method to generate a mass image of a voxelized volume
    /gate/{volume name}/geometry/buildAndDumpMassImage {path to mass image + mass image filename (.mhd)}
  • Addition of a method to generate a voxelized image from a arbitrary unvoxelized geometry
  1. It is mandatory to use this method on the world volume
  2. it is mandatory to place the three following commands after the definition of the geometry of all volumes
  3. It is mandatory to not have a voxelized volume in the geometry
/gate/world/setSaveImageDirectory  {path to a folder (image and HU2mat filenames are automaticaly generated)}   
/gate/world/saveGeometryAsVoxelizedImage {x voxel size} {y voxel size} {z voxel size} {unit (mm)}

TomThePhysicist added some commits Jan 9, 2017

Fix: correction of HU indices out of range bug
  Who was triggered when GateVImageVolume::LoadImage(bool add1VoxelMargin) was used with
  add1VoxelMargin = true (for example in GateImageRegionalizedVolume)
Merge branch develop into VoxelizedMass-dev
  - Resolving conflics in
  - Homogenization of typo in

This comment has been minimized.

Copy link

djboersma commented Oct 25, 2018

Cosmetic wish: rename "dump" to something more postive. In daily speech, "dump" has to do with negative things, like "toxic waste dump" or "she dumped her bad boyfriend". Also in computing, "dump" means usually something unpleasant, like in "core dump". But your new feature is something useful and nice, so the word "dump" seems out of place. So how about renaming setDumpPath to setSaveImageDirectory, and dumpVoxelizedGeometry to saveGeometryAsVoxelizedImage, for example?

Renaming VoxelizedGeometry commands
- changing "setDumpPath" to "setSaveImageDirectory",
- changing "dumpVoxelizedGeometry" to "saveGeometryAsVoxelizedImage".

This comment has been minimized.

Copy link
Contributor Author

TomThePhysicist commented Oct 29, 2018

Good remarks, I have changed the name of the commands as you suggested.

@dsarrut dsarrut merged commit 554a2cb into OpenGATE:develop Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.