Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSF time now double (was float). Both write (Actor) and read (Source) #205

Merged
merged 2 commits into from Feb 13, 2019

Conversation

Projects
None yet
2 participants
@dsarrut
Copy link
Contributor

dsarrut commented Nov 19, 2018

GatePhaseSpaceActor used to compute & write the particle time in float. Sometimes not enough, changed to double.

GateSourcePhaseSpace detect if stored time is float or double.

@djboersma

This comment has been minimized.

Copy link
Contributor

djboersma commented Feb 1, 2019

I think this is fine. I remember we had some discussion about this about half a year ago. But I cannot find it, neither in the mail archive nor in the GitHub issues. It would be good to send a message to the user who originally raised this issue, that we think it's now solved. In order not to forget about this, I am waiting with merging and closing this request until we find that original discussion back... :)

@dsarrut dsarrut merged commit 25fdce7 into OpenGATE:develop Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.