Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Proton Nuclear Information Actor #206

Merged
merged 8 commits into from Nov 28, 2018

Conversation

Projects
None yet
3 participants
@SimonRit
Copy link

SimonRit commented Nov 26, 2018

See OpenGATE/GateContrib#23 for an example

#include "G4HadronicProcessStore.hh"
#include "G4HadronicProcess.hh"

#define TRY_AND_EXIT_ON_ITK_EXCEPTION(execFunc) \

This comment has been minimized.

@djboersma

djboersma Nov 27, 2018

Contributor

You define a macro here, but I do not see where you are actually using it. Am I missing something, or is this maybe a leftover from a previous version, and these lines could be removed?

This comment has been minimized.

@SimonRit

SimonRit Nov 27, 2018

Author

Leftover it seems. Sorry for not taking the time to fully clean up Cath's code. I have removed this macro. Thanks!

Simon Rit
Added new actor to record the number of nuclear interactions of protons
The records can be stored in a PhaseSpaceActor using enableNuclearFlag.
This code has been developed by Catherine Therese Quiñones for her
PMB article, http://dx.doi.org/10.1088/0031-9155/61/9/3258.

@SimonRit SimonRit force-pushed the SimonRit:protonnuclear branch from fdee84e to 6ddbd05 Nov 27, 2018


//-----------------------------------------------------------------------------
// Callbacks
void GateProtonNuclearInformationActor::UserSteppingAction(const GateVVolume * v,

This comment has been minimized.

@djboersma

djboersma Nov 27, 2018

Contributor

I do not see where in the code you are selecting protons. Suppose that the track in this step describes a neutron or a carbon ion, which can undergo similar interactions, would this track still get a "proton nuclear information" user info object attached to it?

This comment has been minimized.

@SimonRit

SimonRit Nov 27, 2018

Author

True, it doesn't. If you look at the example on OpenGATE/GateContrib#23, it uses a proton beam and filters protons in the phase space actor. That did the job for Cath's so I think it's worth sharing it as is.

This comment has been minimized.

@djboersma

djboersma Nov 27, 2018

Contributor

But if this actor is actually not specific for protons, then "GateNuclearInformationActor" would be a more correct name, maybe?

This comment has been minimized.

@SimonRit

SimonRit Nov 27, 2018

Author

Currently, it does check for nuclear processes of protons only ("hadElastic" and "protonInelastic"). I don't know if that would work for other particles but my bet is that it requires some adaptations.

@dsarrut dsarrut merged commit 9bb06a7 into OpenGATE:develop Nov 28, 2018

@SimonRit SimonRit deleted the SimonRit:protonnuclear branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.