Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #203 - Dose by region flag was not initialized. #222

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
None yet
3 participants
@SimonRit
Copy link

SimonRit commented Feb 12, 2019

I used to valgrind to fix this. mDoseByRegionsFlag was not initialized so issue #203 was randomly occuring. With mDoseByRegionsFlag set to true, I had the same error message. I added an error message to make the error more explicit but set mDoseByRegionsFlag to false by default.

@dsarrut dsarrut merged commit 56d2dd0 into OpenGATE:develop Feb 13, 2019

@dsarrut

This comment has been minimized.

Copy link
Contributor

dsarrut commented Feb 13, 2019

Awesome, thanks !!

@uhqd

This comment has been minimized.

Copy link
Contributor

uhqd commented Feb 14, 2019

Congratulations for fixing this bug !
Hope this will be in the 8.2 release... Thank you very much anyway.
Small question : there is an internal discussion here to decide where to write the visualisation command line : at its historic place (i.e. at the begining of the .mac) or after the initialize command. Some of us (the religious ones) think that this issue was responsible of this bug. But if I understand well, we can let the visu line at the beginning of the file (please answer, we bet a beer on this issue...). Again thank you.

@SimonRit

This comment has been minimized.

Copy link
Author

SimonRit commented Feb 14, 2019

No, this issue was not responsible of this bug. The code was testing a boolean which was never set. So it basically relied on what was in memory. Depending on what was done before with the memory now occupied by the boolean, it could have been true (non zero) or false (zero). So you could have different behaviors by switching the order of the commands but that was by luck.
As for the order of the commands, I never know when one is allowed to do what. So I'll let someone else answer that question. Yet, I have always set visu before init.
BTW, I like beer too. Cheers! Simon

@uhqd

This comment has been minimized.

Copy link
Contributor

uhqd commented Feb 15, 2019

Ok thank you. Wait you for a beer here...Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.