Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance swap resolve performance #1293

Closed
jodastephen opened this issue Aug 22, 2016 · 0 comments
Closed

Enhance swap resolve performance #1293

jodastephen opened this issue Aug 22, 2016 · 0 comments
Assignees
Milestone

Comments

@jodastephen
Copy link
Member

@jodastephen jodastephen commented Aug 22, 2016

Swap performance can be enhanced through better resolving from SwapTrade to ResolvedSwapTrade.

@jodastephen jodastephen added this to the v1.1 milestone Aug 22, 2016
@jodastephen jodastephen self-assigned this Aug 22, 2016
jodastephen added a commit that referenced this issue Aug 22, 2016
Resolve swap leg using new package scoped constructor
Avoids recalculating the currency of the swap leg
Use similar package scoped constructors elsewhere in swaps
Performance gain of around 18% on `SwapPricePerformance`
Fixes #1293
@cjkent cjkent closed this in #1294 Aug 22, 2016
cjkent added a commit that referenced this issue Aug 22, 2016
Resolve swap leg using new package scoped constructor
Avoids recalculating the currency of the swap leg
Use similar package scoped constructors elsewhere in swaps
Performance gain of around 18% on `SwapPricePerformance`
Fixes #1293
@cjkent cjkent removed the Status:InReview label Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.