Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance swap resolve performance #1293

Closed
jodastephen opened this issue Aug 22, 2016 · 0 comments
Closed

Enhance swap resolve performance #1293

jodastephen opened this issue Aug 22, 2016 · 0 comments
Assignees
@jodastephen
Labels
Type:Enhancement
Milestone
v1.1

Comments

@jodastephen
Copy link
Member

Swap performance can be enhanced through better resolving from SwapTrade to ResolvedSwapTrade.
@jodastephen jodastephen added this to the v1.1 milestone Aug 22, 2016
@jodastephen jodastephen self-assigned this Aug 22, 2016
jodastephen added a commit that referenced this issue Aug 22, 2016
@jodastephen
Enhance swap performance
4d7b5a6 
Resolve swap leg using new package scoped constructor
Avoids recalculating the currency of the swap leg
Use similar package scoped constructors elsewhere in swaps
Performance gain of around 18% on `SwapPricePerformance`
Fixes #1293
@jodastephen jodastephen mentioned this issue Aug 22, 2016
Merged
cjkent pushed a commit that referenced this issue Aug 22, 2016
@jodastephen @cjkent
Enhance swap performance (#1294)
f4ed86b 
Resolve swap leg using new package scoped constructor
Avoids recalculating the currency of the swap leg
Use similar package scoped constructors elsewhere in swaps
Performance gain of around 18% on `SwapPricePerformance`
Fixes #1293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodastephen jodastephen

Labels
Type:Enhancement
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
2 participants
@cjkent @jodastephen