Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRA payment dates not alway correctly adjusted #1301

Closed
jodastephen opened this issue Aug 23, 2016 · 0 comments
Closed

FRA payment dates not alway correctly adjusted #1301

jodastephen opened this issue Aug 23, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@jodastephen
Copy link
Member

@jodastephen jodastephen commented Aug 23, 2016

The existing logic to create a FRA from a convention performs business day adjustment incorrectly. This could result in payment on a holiday.

At trade creation, the start and end dates should be determined and adjusted. The payment date offset should be applied to the adjusted start date. The FRA product should then be created using the adjusted start date, the adjusted end date and the adjusted payment date.

During resolving/pricing, the start and end dates should not be further adjusted. The payment date should retain the ability to be re-adjusted in case an additional holiday has been added.

See http://forums.opengamma.com/t/fra-present-value-calculation-possible-bug/586

@jodastephen jodastephen added this to the v1.1 milestone Aug 23, 2016
@jodastephen jodastephen self-assigned this Aug 23, 2016
jodastephen added a commit that referenced this issue Aug 23, 2016
Start and end date should be adjusted when trade is created, not later
Payment date should be offset and adjusted when trade is created
Payment date should be re-adjusted when resolved
Fixes #1301
jodastephen added a commit that referenced this issue Aug 23, 2016
Start and end date should be adjusted when trade is created, not later
Payment date should be offset and adjusted when trade is created
Payment date should be re-adjusted when resolved
Fixes #1301
yukiiwashita added a commit that referenced this issue Aug 23, 2016
Start and end date should be adjusted when trade is created, not later
Payment date should be offset and adjusted when trade is created
Payment date should be re-adjusted when resolved
Fixes #1301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.