Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExplainKey.FROM_FIXING_SERIES is only populated if the fixing date equals the valuation date #1380

Closed
cjkent opened this issue Oct 10, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@cjkent
Copy link
Member

@cjkent cjkent commented Oct 10, 2016

This seems surprising. It would seem reasonable to populate it if the fixing date is on or before the valuation date and the fixing series contains the fixing date. The Javadoc says

"The flag to indicate that the that the observed value is from a fixing time-series."

The valuation date isn't mentioned anywhere and the user of this field needs to know how it's populated.

@jodastephen
Copy link
Member

@jodastephen jodastephen commented Oct 10, 2016

The implementation in IborIndexRates is wrong

jodastephen added a commit that referenced this issue Oct 10, 2016
Needs to return true for dates before the valuation date
Fixes #1380
@jodastephen jodastephen added this to the v1.2 milestone Oct 10, 2016
@jodastephen jodastephen self-assigned this Oct 10, 2016
@cjkent cjkent closed this in #1381 Oct 10, 2016
cjkent added a commit that referenced this issue Oct 10, 2016
Needs to return true for dates before the valuation date
Fixes #1380
@cjkent cjkent removed the Status:InReview label Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.