Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overload methods on EtdIdUtils to take EtdContractSpec and security instances #1497

Closed
cjkent opened this issue Mar 13, 2017 · 2 comments
Closed
Milestone

Comments

@cjkent
Copy link
Member

@cjkent cjkent commented Mar 13, 2017

EtdIdUtils has helper methods to create IDs for EtdContractSpec, EtdOptionSecurity and EtdFutureSecurity. These methods have separate parameters for each item of information, for example the exchange ID and contract code.

There are cases where you need to generate an ID from an existing contract spec or security and it would be useful if there were overloads for this.

@cjkent cjkent changed the title Overload method on EtdIdUtils to take EtdContractSpec and security instances Overload methods on EtdIdUtils to take EtdContractSpec and security instances Mar 13, 2017
@jodastephen
Copy link
Member

@jodastephen jodastephen commented Mar 30, 2017

EtdFutureSecurity.of() already exists to do this? Or am I missing something.

@cjkent
Copy link
Member Author

@cjkent cjkent commented Mar 30, 2017

No, it was me that was missing something :)

@cjkent cjkent closed this Mar 30, 2017
@jodastephen jodastephen modified the milestone: v1.3 May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.