Bond API #1368
Merged
Bond API #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface for `LegalEntityDiscountingProvider` See #1331
jodastephen
force-pushed
the
topic/bond-measures
branch
from
fd473f1
to
908d7ec
Compare
`LegalEntityDiscountingProvider` is now an interface `ImmutableLegalEntityDiscountingProvider` is the class `BondGroup` is renamed to `RepoGroup` It was not possible to deprecate in a sensible way See #1331
yukiiwashita
reviewed
Oct 4, 2016
| } | ||
|
|
||
| //------------------------------------------------------------------------- | ||
| /** |
There was a problem hiding this comment.
Remove this as the same comment is in the interface.
yukiiwashita
reviewed
Oct 4, 2016
| } | ||
|
|
||
| //------------------------------------------------------------------------- | ||
| /** |
There was a problem hiding this comment.
Remove this as the same comment is in the interface.
yukiiwashita
approved these changes
Oct 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change renames
LegalEntityDiscountingProvidertoImmutableLegalEntityDiscountingProviderand adds a new interface calledLegalEntityDiscountingProvider. It also renamesBondGrouptoRepoGroupwith all associated access methods and properties renamed. WithinImmutableLegalEntityDiscountingProvider,bondMapis renamed torepoCurveGroups, andlegalEntityMapis renamed toissuerCurveGroups. All this is backwards incompatible.The incompatibility was driven by two separate flaws. Firstly, the provider should not have referred to bonds, as it will be used for bills at some point in the future. Secondly, there should always have been a separation between the class and interface to allow for the calculation/measure API to be added.
An attempt was made to add deprecated workarounds, but with two interlinked issues, the deprecations were not practical. Migration should not be complex, simply rename each item as listed above.
See #1331