Bond API #1368

Merged
merged 3 commits into from Oct 4, 2016

Conversation

Projects
None yet
2 participants
@jodastephen
Member

jodastephen commented Oct 3, 2016

This change renames LegalEntityDiscountingProvider to ImmutableLegalEntityDiscountingProvider and adds a new interface called LegalEntityDiscountingProvider. It also renames BondGroup to RepoGroup with all associated access methods and properties renamed. Within ImmutableLegalEntityDiscountingProvider, bondMap is renamed to repoCurveGroups, and legalEntityMap is renamed to issuerCurveGroups. All this is backwards incompatible.

The incompatibility was driven by two separate flaws. Firstly, the provider should not have referred to bonds, as it will be used for bills at some point in the future. Secondly, there should always have been a separation between the class and interface to allow for the calculation/measure API to be added.

An attempt was made to add deprecated workarounds, but with two interlinked issues, the deprecations were not practical. Migration should not be complex, simply rename each item as listed above.

See #1331

Add BondDiscountingProvider interface
Interface for `LegalEntityDiscountingProvider`
See #1331
Change LegalEntityDiscountingProvider to interface
`LegalEntityDiscountingProvider` is now an interface
`ImmutableLegalEntityDiscountingProvider` is the class
`BondGroup` is renamed to `RepoGroup`
It was not possible to deprecate in a sensible way
See #1331
+ }
+
+ //-------------------------------------------------------------------------
+ /**

This comment has been minimized.

@yukiiwashita

yukiiwashita Oct 4, 2016

Member

Remove this as the same comment is in the interface.

@yukiiwashita

yukiiwashita Oct 4, 2016

Member

Remove this as the same comment is in the interface.

+ }
+
+ //-------------------------------------------------------------------------
+ /**

This comment has been minimized.

@yukiiwashita

yukiiwashita Oct 4, 2016

Member

Remove this as the same comment is in the interface.

@yukiiwashita

yukiiwashita Oct 4, 2016

Member

Remove this as the same comment is in the interface.

@jodastephen jodastephen changed the title from Add BondDiscountingProvider interface to Bond API Oct 4, 2016

@yukiiwashita yukiiwashita merged commit 20d5df5 into master Oct 4, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@yukiiwashita yukiiwashita deleted the topic/bond-measures branch Oct 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment