Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GBP/EUR cross-currency convention. #1390

Merged
merged 2 commits into from Oct 17, 2016
Merged

Added GBP/EUR cross-currency convention. #1390

merged 2 commits into from Oct 17, 2016

Conversation

@marc-henrard
Copy link
Contributor

@marc-henrard marc-henrard commented Oct 17, 2016

No description provided.

* GBP LIBOR 3M v EUR EURIBOR 3M.
* The spread is on the GBP leg.
*/
public static final XCcyIborIborSwapConvention GBP_LIBOR_3M_EUR_EURIBOR_3M =

This comment has been minimized.

@jodastephen

jodastephen Oct 17, 2016
Member

Since EUR/GBP is the correct way around for the currency pair, I suspect this should be named EUR_EURIBOR_3M _GBP_LIBOR_3M. Unless we are naming them to indicate the order of the spread leg? (I'm happy with either convention, but we should document the naming convention we are using in a comment in the class)

This comment has been minimized.

@marc-henrard

marc-henrard Oct 17, 2016
Author Contributor

I had in mind to keep the leg with the market quote as the first one. This is what we have done for all others (FIXED v LIBOR, XCCY, IBOR+spread v IBOR). I will add some comments in that direction in the java doc.

@jodastephen jodastephen added this to the v1.2 milestone Oct 17, 2016
@marc-henrard marc-henrard merged commit 5d1a249 into master Oct 17, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jodastephen jodastephen deleted the topic/xccy-gbp-eur branch Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.