Allow base sensitivity to be split #1424

Merged
merged 3 commits into from Dec 19, 2016

Conversation

Projects
None yet
2 participants
@jodastephen
Member

jodastephen commented Dec 1, 2016

Add combine/split concept to base sensitivity classes
Fixes #1423

@marc-henrard

A question on 'ParameterSize' and it relation with 'CurveParameterSize'. Do we need two objects?
Can be merged if two similar names are fine for you.
Also a typo in a javadoc.

+ * For example, the curve name and the number of curve nodes.
+ */
+@BeanDefinition(builderScope = "private")
+public final class ParameterSize

This comment has been minimized.

@marc-henrard

marc-henrard Dec 16, 2016

Contributor

This is very similar to the object 'CurveParameterSize'. Do we want to keep both?

@marc-henrard

marc-henrard Dec 16, 2016

Contributor

This is very similar to the object 'CurveParameterSize'. Do we want to keep both?

+ /**
+ * The split of parameters between the underlying parameterized data.
+ * <p>
+ * A single {@code UnitParameterSensitivity} represents the sensitivity to a single {@link ParameterizedData} instance.

This comment has been minimized.

@marc-henrard

marc-henrard Dec 16, 2016

Contributor

CurrencyParameterSensitivity instead of UnitParameterSensitivity

@marc-henrard

marc-henrard Dec 16, 2016

Contributor

CurrencyParameterSensitivity instead of UnitParameterSensitivity

+ /**
+ * Gets the split of parameters between the underlying parameterized data.
+ * <p>
+ * A single {@code UnitParameterSensitivity} represents the sensitivity to a single {@link ParameterizedData} instance.

This comment has been minimized.

@marc-henrard

marc-henrard Dec 16, 2016

Contributor

As above

@marc-henrard

marc-henrard Dec 16, 2016

Contributor

As above

jodastephen added some commits Dec 1, 2016

Allow base sensitivity to be split
Add combine/split concept to base sensitivity classes
Fixes #1423
@jodastephen

This comment has been minimized.

Show comment
Hide comment
@jodastephen

jodastephen Dec 19, 2016

Member

We'll keep CurveParameterSize separate from ParameterSize as the curve version is used on existing APIs and there is no great need to change.

Member

jodastephen commented Dec 19, 2016

We'll keep CurveParameterSize separate from ParameterSize as the curve version is used on existing APIs and there is no great need to change.

@jodastephen jodastephen merged commit cb4f333 into master Dec 19, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jodastephen jodastephen deleted the topic/sensitivty2 branch Dec 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment