Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended enum case insensitive lookup #1436

Merged
merged 1 commit into from Dec 15, 2016
Merged

Conversation

@jodastephen
Copy link
Member

@jodastephen jodastephen commented Dec 14, 2016

Allow extended enums to be looked up by upper case name
as well as by correct name

Allow extended enums to be looked up by upper case name
as well as by correct name
@@ -19,11 +22,11 @@
*/
static final ImmutableReferenceData STANDARD;
static {
ImmutableMap.Builder<ReferenceDataId<?>, Object> builder = ImmutableMap.builder();
Map<ReferenceDataId<?>, Object> map = new HashMap<>();

This comment has been minimized.

@andreiruse

andreiruse Dec 14, 2016
Contributor

Not related to the changes, why not Map<ReferenceDataId<?>, HolidayCalendar> ?

Also, same question for the next static{} block below

This comment has been minimized.

@jodastephen

jodastephen Dec 15, 2016
Author Member

Reference data can hold many different things, not just holidays,

@jodastephen jodastephen merged commit 3a9e2ba into master Dec 15, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jodastephen jodastephen deleted the topic/case-insensitive branch Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.