Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate CalculationListener.calculationsStarted() #1458

Merged
merged 1 commit into from Dec 24, 2016

Conversation

@cjkent
Copy link
Member

@cjkent cjkent commented Dec 23, 2016

Propagate CalculationListener.calculationsStarted() to the delegate listener in UnwrappingListener and add a test.

This is a fix for a bug introduced with CalculationListener.calculationsStarted(). The calculations would never complete if the calculations were requested via CalculationRunner.calculateAsync(). That code path wasn't covered by the existing tests and was the only one affected by the issue.

@jodastephen jodastephen merged commit 45e0aae into master Dec 24, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jodastephen jodastephen deleted the topic/propagate-calculations-started branch Dec 24, 2016
@jodastephen jodastephen modified the milestone: v1.2 Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.