Add FpML parsing for CDS and CDX #1474

Merged
merged 2 commits into from Jan 20, 2017

Conversation

Projects
None yet
2 participants
@jodastephen
Member

jodastephen commented Jan 19, 2017

Ensure lots of sample FpML files parse

Add FpML parsing for CDS and CDX
Ensure lots of sample FpML files parse
+
+ // handle a single protectionTerms element
+ XmlElement protectionTermEl = cdsEl.getChild("protectionTerms");
+ CurrencyAmount notional = document.parseCurrencyAmount(protectionTermEl.getChild("calculationAmount"));

This comment has been minimized.

@yukiiwashita

yukiiwashita Jan 20, 2017

Member

Is it helpful to check the notional values in the two fields are the same?

@yukiiwashita

yukiiwashita Jan 20, 2017

Member

Is it helpful to check the notional values in the two fields are the same?

This comment has been minimized.

@jodastephen

jodastephen Jan 20, 2017

Member

I think we can ignore the issue for now.

@jodastephen

jodastephen Jan 20, 2017

Member

I think we can ignore the issue for now.

*/
@PropertyDefinition(validate = "notNull")
private final ProtectionStartOfDay protectionStart;
/**
* The number of days between valuation date and step-in date.
* <p>
* The step-in date is also called protection effective date.
- * It is usually 1 calendar day for standardized CDS index contracts.
+ * It is usually 1 calendar day for standardized CDS contracts.

This comment has been minimized.

@yukiiwashita

yukiiwashita Jan 20, 2017

Member

CDS -> CDS index

@yukiiwashita

yukiiwashita Jan 20, 2017

Member

CDS -> CDS index

+ * <p>
+ * The following features are not available in the Strata trade model:
+ * <ul>
+ * <li>initial fixing date

This comment has been minimized.

@yukiiwashita

yukiiwashita Jan 20, 2017

Member

These comments are relevant for CDSs?

@yukiiwashita

yukiiwashita Jan 20, 2017

Member

These comments are relevant for CDSs?

@yukiiwashita yukiiwashita merged commit 4de7a53 into topic/cds-merge Jan 20, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jodastephen jodastephen deleted the topic/cds-fpml branch Jan 23, 2017

@jodastephen jodastephen modified the milestone: v1.2 Feb 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment