Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FpML parsing for CDS and CDX #1474

Merged
merged 2 commits into from
Jan 20, 2017
Merged

Conversation

jodastephen
Copy link
Member

Ensure lots of sample FpML files parse

Ensure lots of sample FpML files parse

// handle a single protectionTerms element
XmlElement protectionTermEl = cdsEl.getChild("protectionTerms");
CurrencyAmount notional = document.parseCurrencyAmount(protectionTermEl.getChild("calculationAmount"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it helpful to check the notional values in the two fields are the same?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can ignore the issue for now.

*/
@PropertyDefinition(validate = "notNull")
private final ProtectionStartOfDay protectionStart;
/**
* The number of days between valuation date and step-in date.
* <p>
* The step-in date is also called protection effective date.
* It is usually 1 calendar day for standardized CDS index contracts.
* It is usually 1 calendar day for standardized CDS contracts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CDS -> CDS index

* <p>
* The following features are not available in the Strata trade model:
* <ul>
* <li>initial fixing date
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments are relevant for CDSs?

@yukiiwashita yukiiwashita merged commit 4de7a53 into topic/cds-merge Jan 20, 2017
@jodastephen jodastephen deleted the topic/cds-fpml branch January 23, 2017 11:27
@jodastephen jodastephen modified the milestone: v1.2 Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants