Skip to content

Enhance ETD products#1496

Merged
jodastephen merged 7 commits into
developfrom
topic/etd
Mar 8, 2017
Merged

Enhance ETD products#1496
jodastephen merged 7 commits into
developfrom
topic/etd

Conversation

@jodastephen

Copy link
Copy Markdown
Contributor

Add additional interfaces and standard identifiers.

@cjkent cjkent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an unfinished Javadoc but it's not worth delaying the merge

* Creates an identifier for a contract specification.
* <p>
* This will have the format:
* {@code 'OG-ETD~F:ECAG:FGBS'} or {@code 'OG-ETD~O:ECAG:OGBS'}.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the example IDs in this class are still using a colon as a separator.

/**
* The type of ETD - Monthly, Weekly or Daily.
* <p>
* Flex

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfinished comment

@jodastephen jodastephen merged commit 19e7b4c into develop Mar 8, 2017
@jodastephen jodastephen deleted the topic/etd branch March 8, 2017 17:48
@jodastephen jodastephen modified the milestone: v1.3 Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants