Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ETD products #1496

Merged
merged 7 commits into from Mar 8, 2017
Merged

Enhance ETD products #1496

merged 7 commits into from Mar 8, 2017

Conversation

@jodastephen
Copy link
Member

jodastephen commented Mar 8, 2017

Add additional interfaces and standard identifiers.

jodastephen added 4 commits Mar 6, 2017
Include support for Flex futures/options
Change design to simplify Flex
jodastephen added 2 commits Mar 8, 2017
@cjkent
cjkent approved these changes Mar 8, 2017
Copy link
Member

cjkent left a comment

There's an unfinished Javadoc but it's not worth delaying the merge

* Creates an identifier for a contract specification.
* <p>
* This will have the format:
* {@code 'OG-ETD~F:ECAG:FGBS'} or {@code 'OG-ETD~O:ECAG:OGBS'}.

This comment has been minimized.

Copy link
@cjkent

cjkent Mar 8, 2017

Member

All the example IDs in this class are still using a colon as a separator.

/**
* The type of ETD - Monthly, Weekly or Daily.
* <p>
* Flex

This comment has been minimized.

Copy link
@cjkent

cjkent Mar 8, 2017

Member

Unfinished comment

@jodastephen jodastephen merged commit 19e7b4c into develop Mar 8, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jodastephen jodastephen deleted the topic/etd branch Mar 8, 2017
@jodastephen jodastephen modified the milestone: v1.3 Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.