Enhance ETD products#1496
Merged
Merged
Conversation
Include support for Flex futures/options
Change design to simplify Flex
cjkent
approved these changes
Mar 8, 2017
cjkent
left a comment
Contributor
There was a problem hiding this comment.
There's an unfinished Javadoc but it's not worth delaying the merge
| * Creates an identifier for a contract specification. | ||
| * <p> | ||
| * This will have the format: | ||
| * {@code 'OG-ETD~F:ECAG:FGBS'} or {@code 'OG-ETD~O:ECAG:OGBS'}. |
Contributor
There was a problem hiding this comment.
All the example IDs in this class are still using a colon as a separator.
| /** | ||
| * The type of ETD - Monthly, Weekly or Daily. | ||
| * <p> | ||
| * Flex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additional interfaces and standard identifiers.