Enhance ETD products #1496

Merged
merged 7 commits into from Mar 8, 2017

Conversation

Projects
None yet
2 participants
@jodastephen
Member

jodastephen commented Mar 8, 2017

Add additional interfaces and standard identifiers.

jodastephen added some commits Mar 6, 2017

Add standard ETD identifiers
Include support for Flex futures/options
Rename EtdStyle to EtdVariant
Change design to simplify Flex

jodastephen added some commits Mar 8, 2017

@cjkent

cjkent approved these changes Mar 8, 2017

There's an unfinished Javadoc but it's not worth delaying the merge

+ * Creates an identifier for a contract specification.
+ * <p>
+ * This will have the format:
+ * {@code 'OG-ETD~F:ECAG:FGBS'} or {@code 'OG-ETD~O:ECAG:OGBS'}.

This comment has been minimized.

@cjkent

cjkent Mar 8, 2017

Member

All the example IDs in this class are still using a colon as a separator.

@cjkent

cjkent Mar 8, 2017

Member

All the example IDs in this class are still using a colon as a separator.

+ /**
+ * The type of ETD - Monthly, Weekly or Daily.
+ * <p>
+ * Flex

This comment has been minimized.

@cjkent

cjkent Mar 8, 2017

Member

Unfinished comment

@cjkent

cjkent Mar 8, 2017

Member

Unfinished comment

@jodastephen jodastephen merged commit 19e7b4c into develop Mar 8, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jodastephen jodastephen deleted the topic/etd branch Mar 8, 2017

@jodastephen jodastephen modified the milestone: v1.3 Mar 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment