Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ETD products #1496

Merged
merged 7 commits into from Mar 8, 2017
Merged

Enhance ETD products #1496

merged 7 commits into from Mar 8, 2017

Conversation

jodastephen
Copy link
Member

@jodastephen jodastephen commented Mar 8, 2017

Add additional interfaces and standard identifiers.

cjkent
cjkent approved these changes Mar 8, 2017
Copy link
Contributor

@cjkent cjkent left a comment

There's an unfinished Javadoc but it's not worth delaying the merge

* Creates an identifier for a contract specification.
* <p>
* This will have the format:
* {@code 'OG-ETD~F:ECAG:FGBS'} or {@code 'OG-ETD~O:ECAG:OGBS'}.
Copy link
Contributor

@cjkent cjkent Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the example IDs in this class are still using a colon as a separator.

/**
* The type of ETD - Monthly, Weekly or Daily.
* <p>
* Flex
Copy link
Contributor

@cjkent cjkent Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfinished comment

@jodastephen jodastephen merged commit 19e7b4c into develop Mar 8, 2017
2 checks passed
@jodastephen jodastephen deleted the topic/etd branch Mar 8, 2017
@jodastephen jodastephen modified the milestone: v1.3 Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants